Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[guiinfo][PVR] Another bunch of (PVR) guiinfo fixes and improvements #13651

Merged
merged 7 commits into from Mar 16, 2018

Conversation

@ksooo
Copy link
Member

commented Mar 15, 2018

  1. Fixed PVR.EpgEventDuration, PVR.EpgEvent(Elapsed|Remaining|Finish)Time to support channel preview. Look for the changing times in the OSD when using channel preview...

  2. PVR.EpgEventDuration, PVREpgEvent(Elapsed|Remaining|Finish|Seek)Time, PVR.Timeshift(Start|Cur|End|Offset) now support time format strings. Example: $INFO[PVR.EpgEventElapsedTime(hh:mm:ss)]

  3. All (!) labels using time format strings now support the new formats 'secs' 'mins' and 'hours'. Example: Player.Duration for a 145 minutes movie: hh:mm:ss=02:25:00, hh=02, mm=25, ss=00, hours=2, mins=145, secs=8700

  4. ListItem.Duration now supports time format strings. Example: $INFO[ListItem.Duration(mins)]

  5. Some random refactorings and fixes along the way.

@ronie @phil65 @HitcherUK @BigNoid heads-up, please. Would be nice if one of you could announce this changes in the forum. ;-)
@Jalle19 are you in the mood for another code review?

ksooo added 7 commits Mar 13, 2018
…maining|Finish)Time to support channel preview.
…rentItem (param 'blocking' was removed long time ago.
…SetCurrentItem if the channel to play/preview actually has changed.
…Remaining|Finish|Seek)Time, PVR.Timeshift(Start|Cur|End|Offset) now support time format strings.
…s 'secs' 'mins' and 'hours' (Example: Player.Duration for a 145 minutes movie: hh:mm:ss=2:25:00, hh=2, mm=25, ss=0, hours=2, mins=145, secs=8700).
break;
default:
return false;
}
return true;

This comment has been minimized.

Copy link
@Jalle19

Jalle19 Mar 16, 2018

Member

It seems this line can't be reached anymore

This comment has been minimized.

Copy link
@ksooo

ksooo Mar 16, 2018

Author Member

It can. You see see break; in line 842, just as an example.

@ksooo ksooo merged commit dd9a374 into xbmc:master Mar 16, 2018
1 check passed
1 check passed
default You're awesome. Have a cookie
Details
@ksooo ksooo deleted the ksooo:pvr-guiinfo-2 branch Mar 16, 2018
gade01 added a commit to gade01/Rapier that referenced this pull request Mar 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.