Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[win32] fix crash after #13722 + cosmetics #13728

Merged
merged 3 commits into from Apr 3, 2018

Conversation

@afedchin
Copy link
Member

commented Apr 3, 2018

see title

Copy link
Member

left a comment

thanks very much!

@afedchin afedchin merged commit 363475b into xbmc:master Apr 3, 2018
1 check passed
1 check passed
default You're awesome. Have a cookie
Details
@afedchin afedchin deleted the afedchin:win32-fix branch Apr 3, 2018
@DaveTBlake

This comment has been minimized.

Copy link
Member

commented Apr 3, 2018

Thanks for this @afedchin, but now master is giving me crashes on exit. Seems to be from CGUIWindowManager::DeInitialize() so related to this or #13722?

@FernetMenta

This comment has been minimized.

Copy link
Member

commented Apr 3, 2018

#13724 will fix this

@DaveTBlake

This comment has been minimized.

Copy link
Member

commented Apr 3, 2018

So really @FernetMenta I had best just give up on trying to rebase and get a working test build until all the global killing is over?

@garbear

This comment has been minimized.

Copy link
Member

commented Apr 3, 2018

@DaveTBlake global killing is never truly over with Kodi :) I have a few lined up, but yea I'll ping you whenever I open a PR. I've never failed to break something with a globals refactor :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.