Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
[videolibrary] Assign extra artwork from file system #13859
with a whitelist configuration in AS.xml, and apply the whitelist to scraper results.
Find and assign extra artwork like 'clearlogo' and 'landscape' from the local file system. Configured with a whitelist in advancedsettings.xml, which also applies to artwork from scrapers. Scrapers may not need switches for each individual art type, leaving that up to this configuration.
Files must be named as the name used in the library, so 'clearlogo.png' or 'movie file name-clearlogo.png', not 'logo.png'. Kodi exports the artwork to these file names.
"banner" is still hard-coded for TV shows and seasons. That's still wired up as a fallback "thumb" in some places that will be best handled in another PR. And "fanart" is still hard-coded for most media items, as that is treated differently than other artwork in many parts of Kodi.
Movie set artwork isn't exactly supported; when a new movie set is added Kodi still copies all artwork from one of the movies, which can be limited by
White list configuration modeled on Dave's work on #13848 for the music library.
<advancedsettings> <videolibrary> <tvshowextraart> <arttype>clearlogo</arttype> <arttype>landscape</arttype> </tvshowextraart> <movieextraart> <arttype>landscape</arttype> </movieextraart> </videolibrary> </advancedsettings>
How Has This Been Tested?
Manually, testing movies and TV shows with a couple configurations. Could use more eyes.
Types of change
Please take a look at this conversation in the board regarding the filenamings:
May 17, 2018
Do you have any suggestions on how to add this to the standard settings? I took a look through the settings implementation and I just don't see how to go about it.
I'm also not sure how to present the options in the GUI; the best I can think of is a simple multiselect dialog populated with art types already in the library plus a button to add an additional type with the keyboard, but that will still be awkward with many artwork types configured for each media type.
I seem to remember reading that advancesettings was just the first step as the GUI settings wasn't ready for this type. I may be totally making that up though @DaveTBlake will know ;)
My own personal opinion (if anyone cares) is advancedsettings is perfect for this type of thing. The idea that we remove advancedsettings would imo make our GUI settings far too complicated so its worth a debate rather than saying its wrong. Anyway this is a discussion for the forum I guess: https://forum.kodi.tv/showthread.php?tid=331555
I have created some new Estuary views to take advantage of the landscape views for TVShows. It looks awesome but doing it manually, or with artwork beef is a pain. @MartijnKaijser any ideas on how to move this forward so we can get this on a par with the new music artwork functionality? That has been very positively received in the artwork creators community.