Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix whitelistable resolutions on some platforms #13904

Merged
merged 4 commits into from Jun 4, 2018

Conversation

@lrusak
Copy link
Contributor

commented May 17, 2018

after #13899 RES_DESKTOP won't show up in the whitelist selection on some platforms. This fixes it.

basically we were taking out the preferred resolution from the list of custom resolutions.

lrusak added 4 commits May 17, 2018
…TOP"

This reverts commit d487155.
@FernetMenta

This comment has been minimized.

Copy link
Member

commented May 18, 2018

basically we were taking out the preferred resolution from the list of custom resolutions.

if this is the case, there is still someting wrong. the preferred res, that one the UI uses, is stored in guisettings and can be queried with CDisplaySettings::GetInstance().GetCurrentResolution()

@lrusak

This comment has been minimized.

Copy link
Contributor Author

commented May 19, 2018

good to go?

@lrusak

This comment has been minimized.

Copy link
Contributor Author

commented Jun 4, 2018

jenkins build and merge

@jenkins4kodi jenkins4kodi merged commit 191a221 into xbmc:master Jun 4, 2018
1 check was pending
1 check was pending
default Found some time, building it now.
Details
@Rechi Rechi added this to the Leia 18.0-alpha2 milestone Jun 4, 2018
@wrxtasy

This comment has been minimized.

Copy link
Contributor

commented Jun 9, 2018

@lrusak

Android ARM nightly #dba439f5 anomalies 23.98 and 60Hz are selectable in Refresh Rate, but 1080p 60Hz has gone missing in Whitelist.
http://paste.kodi.tv/tiqimosewu

Nightly #05a868b3 , 23.98 is missing in both refresh rate & Whitelist resolutions. 1080p 60Hz shows up this time:
http://paste.kodi.tv/tipiwiwafa

All these Fractional refresh rates were working perfectly before this Whitelist business was introduced.
I'm questioning the sanity of what has been now been introduced particularly for Kodi support members downstream fielding questions and clueless users.

Whatever happened to the KISS method - keep it simple stupid ?
This is what I use in combo with @koying's previous Krypton resolution switching PR to prevent unnecessary SD <<-->> HD switching res. when watching OTA TV with LibreELEC:

http://paste.kodi.tv/oxozekahuy.php

W.

@FernetMenta

This comment has been minimized.

Copy link
Member

commented Jun 9, 2018

this is a dev space. you can complain in the forum. here you are supposed to talk about code. if you don't, don't post here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.