Ability to skip specific key/button map translations when running in standalone mode #1391

Closed
wants to merge 1 commit into
from

Projects

None yet

3 participants

@mkortstiege
Member

This commit disables the "ToggleFullScreen" mapping in standalone mode (only) without the need to hack the actual keymap files.

@t-nelson
Contributor
t-nelson commented Sep 9, 2012

Any thoughts on overriding this in the case debug is enabled from GUI settings?

@mkortstiege
Member

No thoughts about it really. Mind explaining why it should be disabled in case of debug enabled?

@FernetMenta
Member

Shouldn't ToggleFullScreen be better blocked in graphics context when running standalone?

@mkortstiege
Member

@FernetMenta blocking is a really bad idea as some external players want fullscreen and suspend XBMC. Same applies to various launcher addons (emulator and the likes).

@FernetMenta
Member

@vdrfan
We have just discussed this in the Linux forum. Running XBMC standalone needs special handling for X windows, setting the override redirect flag. Not doing so results in poor rendering performance. That means you can't launch other gui application when running XBMC standalone. For those cases you need a window manager.

@mkortstiege
Member

@FernetMenta but running --standalone is possible with a window manager as well. Blocking the toggle would cause some serious issues for all the addons on XBMCbuntu and derivates i'd guess.

@FernetMenta
Member

see #1175
It currently checks for standalone in order to determine if override redirect flag should be set. A different approach would be checking for a window manager: FernetMenta@b1369f4
Some users do weird things, e.g. launching a window manager in a script to bring up a browser. If no WM is present, no other gui applications should be launched nor XBMC minimized or windowed.

@mkortstiege
Member

I'll leave that to you guys ,) I just want to avoid silly toggles that end up in a user nightmare.

@mkortstiege mkortstiege closed this Apr 3, 2013
@tru tru added a commit to plexinc/plex-home-theater-public that referenced this pull request Nov 21, 2014
@tru tru Make PIN input secret
Closes #1391
d87da8d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment