Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[videoplayer] DVDDemux::GetStreamType(): Add more codecs and channel … #13965

Merged
merged 2 commits into from Jun 8, 2018

Conversation

Projects
None yet
3 participants
@ace20022
Copy link
Member

commented Jun 1, 2018

The motivation was that E-AC3 (DD+) was missing. The layout names are take from
https://ffmpeg.org/doxygen/4.0/channel__layout_8c.html#a5fb8d8660239f03323dae7e7c1699f29
Additionally I've renamed Dolby TrueHD to TrueHD

If desired I could strip of the strings in bracket,

@ace20022

This comment has been minimized.

Copy link
Member Author

commented Jun 3, 2018

anyone? maybe @FernetMenta ?

#ifdef FF_PROFILE_DTS_HD_MA
if (profile == FF_PROFILE_DTS_HD_MA)

This comment has been minimized.

Copy link
@FernetMenta

FernetMenta Jun 3, 2018

Member

The ifdef can be dropped. It is always defined

@ace20022

This comment has been minimized.

Copy link
Member Author

commented Jun 8, 2018

good to go?

@FernetMenta

This comment has been minimized.

Copy link
Member

commented Jun 8, 2018

+1

@ace20022 ace20022 merged commit 887956e into xbmc:master Jun 8, 2018

1 check failed

default Sorry, building this PR failed. Please check the logs for the errors.
Details

@ace20022 ace20022 deleted the ace20022:codec_layout_update branch Jun 8, 2018

@Rechi Rechi added this to the Leia 18.0-alpha2 milestone Jun 8, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.