Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

windowing/gbm: set fullscreen flag and other small fixes #13977

merged 4 commits into from Jun 5, 2018


Copy link

commented Jun 5, 2018


This PR updates fullscreen flag and signals that gbm cannot do windowed, makes resolution show as full screen in system information

It also contains some nit-pick fixes:

  • fix DRMUtils SetProperty error check to be more future proof
  • keep buffer locking and release calls even in SetFullScreen
  • pass RESOLUTION_INFO by reference like other windowing systems

Motivation and Context

Show resolution as full screen in system information

How Has This Been Tested?

Running Kodi on Rock64 + LibreELEC

Screenshots (if appropriate):

Types of change

  • Bug fix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves existing functionality)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)


  • My code follows the Code guidelines of this project
  • My change requires a change to the documentation, either Doxygen or wiki
  • I have updated the documentation accordingly
  • I have read the CONTRIBUTING document
  • I have added tests to cover my change
  • All new and existing tests passed
lrusak approved these changes Jun 5, 2018

This comment has been minimized.

Copy link

commented Jun 5, 2018

build failure unrelated

@lrusak lrusak merged commit fd5a8fc into xbmc:master Jun 5, 2018
1 check failed
1 check failed
default Sorry, building this PR failed. Please check the logs for the errors.
@Kwiboo Kwiboo deleted the Kwiboo:gbm-fixes branch Jun 5, 2018
@Rechi Rechi added this to the Leia 18.0-alpha2 milestone Jun 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
3 participants
You can’t perform that action at this time.