addons: don't show a GUI notification for addons installed as a dependency of another addon installation #1398

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
7 participants
@Montellese
Member

Montellese commented Sep 9, 2012

So I recently installed a few addons and I got a GUI notification for every single dependency that was installed with it like the "Common Plugin Cache" or the "Simple Downloader for XBMC Plugins" which IMO can be a bit confusing if you just wanted to install youtube. These addons (services) will never be directly used by the user so why tell them that they have been installed?

@MartijnKaijser

This comment has been minimized.

Show comment
Hide comment
@MartijnKaijser

MartijnKaijser Sep 9, 2012

Member

+1 from me on this. When installing some skins you get tons of new scripts which the user doesn't have to know

Member

MartijnKaijser commented Sep 9, 2012

+1 from me on this. When installing some skins you get tons of new scripts which the user doesn't have to know

@mkortstiege

This comment has been minimized.

Show comment
Hide comment
@mkortstiege

mkortstiege Sep 9, 2012

Member

+1. I think it's more user friendly.

Member

mkortstiege commented Sep 9, 2012

+1. I think it's more user friendly.

@ghost

This comment has been minimized.

Show comment
Hide comment
@ghost

ghost Sep 9, 2012

-1. if shit end up on my system I want to be told. what if apt did this?

ghost commented Sep 9, 2012

-1. if shit end up on my system I want to be told. what if apt did this?

@Montellese

This comment has been minimized.

Show comment
Hide comment
@Montellese

Montellese Sep 9, 2012

Member

I don't follow.

Member

Montellese commented Sep 9, 2012

I don't follow.

@dersphere

This comment has been minimized.

Show comment
Hide comment
@dersphere

dersphere Sep 9, 2012

Member

-1. A dependency can be another (visible) plugin. And a user could wonder why the required video plugin was installed. If he then disables/uninstalls the required plugin the original plugin stops working.

Member

dersphere commented Sep 9, 2012

-1. A dependency can be another (visible) plugin. And a user could wonder why the required video plugin was installed. If he then disables/uninstalls the required plugin the original plugin stops working.

@MartijnKaijser

This comment has been minimized.

Show comment
Hide comment
@MartijnKaijser

MartijnKaijser Sep 9, 2012

Member

You cannot uninstall a dependency plugin and you are told why. Not sure about disable.

Member

MartijnKaijser commented Sep 9, 2012

You cannot uninstall a dependency plugin and you are told why. Not sure about disable.

@Montellese

This comment has been minimized.

Show comment
Hide comment
@Montellese

Montellese Sep 9, 2012

Member

@martijn: AFAIK you can uninstall any addon independent of whether it's a dependency of another addon.

@dersphere: And how does showing a notification during installation help me remember a year later that youtube addon requires Common Cache Plugin? It's not like showing the notification will make sure that you don't uninstall it by accident. For that we'd need some kind of message that warns you that uninstalling addon X might break addons Y and Z because they depend on it.

Member

Montellese commented Sep 9, 2012

@martijn: AFAIK you can uninstall any addon independent of whether it's a dependency of another addon.

@dersphere: And how does showing a notification during installation help me remember a year later that youtube addon requires Common Cache Plugin? It's not like showing the notification will make sure that you don't uninstall it by accident. For that we'd need some kind of message that warns you that uninstalling addon X might break addons Y and Z because they depend on it.

@dersphere

This comment has been minimized.

Show comment
Hide comment
@dersphere

dersphere Sep 9, 2012

Member

@MartijnKaijser: This is going to be offtopic but of course you can uninstall a via dependency installed addon. You can easy reproduce (with eden or master): install "TheHollywoodreporter" which installs "youtube". uninstall "youtube".

@Montellese: You are right. But at least it should be shown on required plugins to have any kind of notification on visible addons.

Member

dersphere commented Sep 9, 2012

@MartijnKaijser: This is going to be offtopic but of course you can uninstall a via dependency installed addon. You can easy reproduce (with eden or master): install "TheHollywoodreporter" which installs "youtube". uninstall "youtube".

@Montellese: You are right. But at least it should be shown on required plugins to have any kind of notification on visible addons.

@arnova

This comment has been minimized.

Show comment
Hide comment
@arnova

arnova Sep 10, 2012

Member

In principle +1. And if we don't, we should at least make clear to the user that those are auto deps being installed...

Member

arnova commented Sep 10, 2012

In principle +1. And if we don't, we should at least make clear to the user that those are auto deps being installed...

@night199uk

This comment has been minimized.

Show comment
Hide comment
@night199uk

night199uk Sep 20, 2012

Contributor

-1 from me, I want to know which plugins get installed so I know when they cause issues.

Contributor

night199uk commented Sep 20, 2012

-1 from me, I want to know which plugins get installed so I know when they cause issues.

@Montellese

This comment has been minimized.

Show comment
Hide comment
@Montellese

Montellese Oct 5, 2012

Member

Closing as there are too many -1s (although there are as many +1s).

Member

Montellese commented Oct 5, 2012

Closing as there are too many -1s (although there are as many +1s).

@Montellese Montellese closed this Oct 5, 2012

@da-anda

This comment has been minimized.

Show comment
Hide comment
@da-anda

da-anda Jan 23, 2013

Member

+1 -> see http://forum.xbmc.org/showthread.php?tid=151774&pid=1308555#pid1308555

We also have to deny disabling/uninstalling of addons that are part of a dependency and also show active dependencies in the addon info-dialog (both ways; "this addon depends on Foo, Bar, Baz;" "required by addons Foo, Bar"). But these features should be added in another PR.

Also I'd probably hide all notifications (e.g. "marked as broken") if a addon was installed as part of a dependency. I don't want to know if common.plugin.cache was updated or not - hell, I don't even know what it does. In doubt, let's add a history/log system and show performed actions in there for those that care, or add an advanced setting to enable the notification spam.

Member

da-anda commented Jan 23, 2013

+1 -> see http://forum.xbmc.org/showthread.php?tid=151774&pid=1308555#pid1308555

We also have to deny disabling/uninstalling of addons that are part of a dependency and also show active dependencies in the addon info-dialog (both ways; "this addon depends on Foo, Bar, Baz;" "required by addons Foo, Bar"). But these features should be added in another PR.

Also I'd probably hide all notifications (e.g. "marked as broken") if a addon was installed as part of a dependency. I don't want to know if common.plugin.cache was updated or not - hell, I don't even know what it does. In doubt, let's add a history/log system and show performed actions in there for those that care, or add an advanced setting to enable the notification spam.

@Montellese Montellese deleted the Montellese:addon_dependency_notifications branch Dec 27, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment