Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PVR][VideoPlayer] Rework and simplify DVDInputStreamPVRManager. #14015

Merged
merged 1 commit into from Jun 12, 2018

Conversation

ksooo
Copy link
Member

@ksooo ksooo commented Jun 10, 2018

  • Simplified interface between PVR inputstream implementation (CDVDInputStreamPVRManager) and PVR component. Removed lots of CPVRClientsboilerplate code. CPVRClients no longer has any knowledge about playing clients.
  • Splitted CDVDInputStreamPVRManager into CInputStreamPVRBase (abstract base class), CInputStreamPVRChannel and CInputStreamPVRRecording. Much cleaner design now, separation of concerns.
  • No functional changes. Basically a big refactoring plus optimizations.

BTW: No idea why git marks DVDInputStreamPVRManager.cpp as deleted. In fact I renamed that file to InputStreamPVRBase.cpp. Most of the code of the original file is actually untouched.

@ksooo ksooo added Type: Cleanup non-breaking change which removes non-working or unmaintained functionality Component: PVR Component: Video v18 Leia labels Jun 10, 2018
@ksooo ksooo added this to the Leia 18.0-alpha2 milestone Jun 10, 2018
@ksooo ksooo requested a review from FernetMenta June 10, 2018 20:32
@ksooo ksooo force-pushed the pvr-inputstream-rework branch 4 times, most recently from 733bbf1 to b8b7c69 Compare June 11, 2018 08:34
@ksooo
Copy link
Member Author

ksooo commented Jun 11, 2018

@MilhouseVH could you please include the PR in your builds and ask testers for reporting back on PVR regressions. I don't think there will be any, but just to be sure.

Copy link
Contributor

@FernetMenta FernetMenta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes seem sound to me.
For the record: CDVDInputStreamPVR* will be disappear. All streaming functions will be moved to InputStreamAddon (v19)

@MilhouseVH
Copy link
Contributor

@ksooo sorry bit behind on emails so this missed tonight's build but it will be in #612 tomorrow.

@ksooo ksooo merged commit e71f05c into xbmc:master Jun 12, 2018
@ksooo ksooo deleted the pvr-inputstream-rework branch June 12, 2018 04:51
@FernetMenta
Copy link
Contributor

@ksooo this most likely killed playing recordings via JSON-RPC. The old code got the recordings tag via CPVRRecordings::GetByPath, the new code assumes that the file item must have a recordings tag, which is not the case if triggers via i.e. Kodi iOS remote app.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: PVR Component: Video Type: Cleanup non-breaking change which removes non-working or unmaintained functionality v18 Leia
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants