Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

json-rpc: fix playing URLs with options #14068

Merged
merged 2 commits into from Jun 18, 2018

Conversation

@FernetMenta
Copy link
Member

commented Jun 17, 2018

fix https://trac.kodi.tv/ticket/17914

If item was already played and stored in DB (without options), JSON-RPC created a playlist with 2 items. First without options, 2nd with options. This behaviour does not make much sense.
Now full url is added as dynPath.

@FernetMenta

This comment has been minimized.

Copy link
Member Author

commented Jun 17, 2018

IMO this entire fileItem logic in JSON-RPC should go away. JSON-RPC is an interface and should not do any magic to the passed parameters

@DaveTBlake

This comment has been minimized.

Copy link
Member

commented Jun 18, 2018

Thanks for this @FernetMenta. Sorry for failing to spot the issue was inside the JSON call not the player, it is an unexpected place for it.

Small thing, but as this fixes an internal JSON issue could you also do a patch bump to the API version https://github.com/xbmc/xbmc/blob/master/xbmc/interfaces/json-rpc/schema/version.txt
to 9.4.1

@FernetMenta

This comment has been minimized.

Copy link
Member Author

commented Jun 18, 2018

I'll leave the API bump to you. PR to this branch

@DaveTBlake DaveTBlake added this to the Leia 18.0-alpha2 milestone Jun 18, 2018

@DaveTBlake

This comment has been minimized.

Copy link
Member

commented Jun 18, 2018

PR raised to do the version bump FernetMenta#477
No idea if that is what you meant, or how it gets to join this PR, but a right faff anyway

@FernetMenta

This comment has been minimized.

Copy link
Member Author

commented Jun 18, 2018

or how it gets to join this PR

it joins at the moment it is merged to the branch

@FernetMenta FernetMenta merged commit 9f8c9ee into xbmc:master Jun 18, 2018

1 check passed

default You're awesome. Have a cookie
Details

@FernetMenta FernetMenta deleted the FernetMenta:jsonrpc branch Jun 18, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.