Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Music]Sources filtering ignore drives without paths #14082

Merged
merged 1 commit into from Jun 21, 2018

Conversation

@DaveTBlake
Copy link
Member

commented Jun 19, 2018

A follow up to #14012 to alow for dynamic automatically mounted sources e.g. CD drive, that appear in the media source list but don't have a path. These were incorrectly being takens as a source for all music items.

On database migration from earlier versions populate the sources table (accidentally omitted before)
So some other very minor code fixes, thanks @phate89

@DaveTBlake

This comment has been minimized.

Copy link
Member Author

commented Jun 20, 2018

Wanting to get this into alpha2, since it fixes what is already there. Fully tested, anyone mind if I merge?

try
{
// Fill source and source paths tables
std::string strSQL;

This comment has been minimized.

Copy link
@Rechi

Rechi Jun 21, 2018

Member

not needed outside the for loop and value isn't needed in next round

{
// Fill source and source paths tables
std::string strSQL;
int idSource;

This comment has been minimized.

Copy link
@Rechi

Rechi Jun 21, 2018

Member

same

…ions

Fix Updatesources for sources with no paths (CD drives etc.)
@DaveTBlake DaveTBlake force-pushed the DaveTBlake:SourcesCDDrive branch from b98ad28 to c0174c6 Jun 21, 2018
@DaveTBlake DaveTBlake merged commit 92d16f4 into xbmc:master Jun 21, 2018
1 check passed
1 check passed
default You're awesome. Have a cookie
Details
@DaveTBlake DaveTBlake deleted the DaveTBlake:SourcesCDDrive branch Jun 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.