Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cmake] fix HandleDepends if only some dependencies have hash checking #14093

Merged
merged 1 commit into from Jun 22, 2018

Conversation

@Rechi
Copy link
Member

commented Jun 22, 2018

Description

If only a subset of dependencies have a hash file (*.sha256) the previous value would be used for dependencies which don't have it.
In case the file doesn't exist unset URL_HASH_COMMAND which may have a value from previous loop iteration.
Also output a warning if the file doesn't exits, which may convince the addon maintainers to add the file.

Types of change

  • Bug fix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves existing functionality)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the Code guidelines of this project
  • My change requires a change to the documentation, either Doxygen or wiki
  • I have updated the documentation accordingly
  • I have read the CONTRIBUTING document
  • I have added tests to cover my change
  • All new and existing tests passed
@Rechi Rechi added this to the Leia 18.0-alpha3 milestone Jun 22, 2018
@Rechi Rechi requested a review from wsnipex Jun 22, 2018
Copy link
Member

left a comment

thanks

@Rechi Rechi merged commit 41dfab3 into xbmc:master Jun 22, 2018
1 check passed
1 check passed
default You're awesome. Have a cookie
Details
@Rechi Rechi deleted the Rechi:fix/cmakeHandleDependsHash branch Jun 22, 2018
Rechi referenced this pull request in xbmc/vfs.libarchive Jun 22, 2018
[depends] add checksum file
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.