Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add required package names #14098

Merged
merged 1 commit into from Jun 25, 2018
Merged

Add required package names #14098

merged 1 commit into from Jun 25, 2018

Conversation

@afeser
Copy link
Contributor

afeser commented Jun 23, 2018

Some required packages were not being installed by the "sudo dnf install ..." command for use of CMake.

Update README.fedora for missing packages

CMake was complaining some packages were missing, add them to dnf install command.
The packages are trousers-devel libidn2-devel gcc-c++ mesa-libGLw-devel libuuid-devel libcurl-devel gtkglext-devel libtool gettext-devel

After the packages installed, usual installation process continues.

Types of change

  • Bug fix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves existing functionality)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the Code guidelines of this project
  • My change requires a change to the documentation, either Doxygen or wiki
  • I have updated the documentation accordingly
  • I have read the CONTRIBUTING document
  • I have added tests to cover my change
  • All new and existing tests passed
Some required packages were not being installed by the "sudo dnf install ..." command for installation.
@hudokkow

This comment has been minimized.

Copy link
Member

hudokkow commented Jun 24, 2018

Thank you for your contribution and congrats on your first PR to Kodi, @afeser. We really appreciate you for taking the time. 👍

However, all build guides have already been rewritten. You can see the latest iteration at #14072 and specifically https://github.com/hudokkow/xbmc/blob/The_X_Files/docs/README.Fedora.md

That said, I would be very grateful if you can test the new guide and get back to me with some feedback. Last time I tested was almost 2 months ago - an eternity in Kodi's development time - and I might have missed something. A quick check tells me my guide is missing gtkglext-devel, for some reason. What Fedora release did you used to test/build?

@hudokkow hudokkow added the No Jenkins label Jun 24, 2018
@hudokkow hudokkow removed their request for review Jun 24, 2018
@hudokkow

This comment has been minimized.

Copy link
Member

hudokkow commented Jun 25, 2018

Merging. I'll rebase and fix my guide.

@hudokkow hudokkow merged commit 8edefdf into xbmc:master Jun 25, 2018
@hudokkow hudokkow added this to the Leia 18.0-alpha3 milestone Jun 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.