Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Estuary] increase space for sysinfo #14100

Merged
merged 1 commit into from Jun 25, 2018

Conversation

@ronie
Copy link
Member

ronie commented Jun 23, 2018

various small tweaks to decrease the risk of truncated labels in the sysinfo window.

before:
before

after:
after

@hudokkow

This comment has been minimized.

Copy link
Member

hudokkow commented Jun 24, 2018

👍

Two comments:

  • In the past we had users asking why Kodi was using so much CPU. We used to explain that it was not only Kodi CPU usage but overall system usage. Someone got tired of explaining the same thing over and over and changed it to System CPU usage to make it a bit more clear. We might start getting the same questions again.
  • I fiddled with this a few weeks ago, trying to have a more sane look. You can see the (tiny) core change I did in https://github.com/hudokkow/xbmc/commits/shorter_cpu_info. Unfortunately, I can't seem to locate the skin changes I did at the time. I was changing on-the-fly and reloading the skin and probably deleted that dev/ install during cleanup. Stupid me. 😠
@MartijnKaijser

This comment has been minimized.

Copy link
Member

MartijnKaijser commented Jun 24, 2018

Agree that string shouldn't change

@ronie ronie force-pushed the ronie:estuary-sysinfo branch from d8ddf2c to 103ac41 Jun 24, 2018
@ronie

This comment has been minimized.

Copy link
Member Author

ronie commented Jun 24, 2018

thanx for the feedback!

string change has been reverted and the cpu info is now trimmed as @hudokkow suggested

new

@hudokkow

This comment has been minimized.

Copy link
Member

hudokkow commented Jun 24, 2018

Just nitpicking but you missed the #. I wasn't a big fan when I changed it but I couldn't find anything better. Your call. Already looks much better. Thanks! 👍

Just a thought but do we really need that kind of precision? I mean #0: 9% vs #0: 9.3%?

@davilla

This comment has been minimized.

Copy link
Contributor

davilla commented Jun 24, 2018

could gain some space by doing '0/9%, 1/10%, 2/25%, etc'

@ronie ronie force-pushed the ronie:estuary-sysinfo branch from 103ac41 to 7ee871b Jun 24, 2018
@ronie

This comment has been minimized.

Copy link
Member Author

ronie commented Jun 25, 2018

updated

@hudokkow

This comment has been minimized.

Copy link
Member

hudokkow commented Jun 25, 2018

IMO, good to go.

@ronie ronie merged commit 6fcbb13 into xbmc:master Jun 25, 2018
1 check passed
1 check passed
default You're awesome. Have a cookie
Details
@Rechi Rechi added this to the Leia 18.0-alpha3 milestone Jun 25, 2018
@ronie ronie deleted the ronie:estuary-sysinfo branch May 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.