[libexif] Added character set conversion to UserComment #1417

Merged
1 commit merged into from Sep 13, 2012

Conversation

Projects
None yet
1 participant
Member

fetzerch commented Sep 13, 2012

This PR adds charset conversion to the EXIF UserComment field.

The current implementation does not handle Unicode comments correctly:
http://trac.xbmc.org/ticket/12628: PicInformation, EXIF "User Comment" shows only 1 char.

My implementation adds a CommentsCharset field to libexif and does the actual conversion outside of the lib in PictureInfoTag.cpp (because we have the CharsetConverter class available there).

You can find the relevant part of the spec here: http://www.exif.org/Exif2-2.PDF (page 28).
I also added 2 example pictures to the bugreport for testing.

@ghost

ghost commented Sep 13, 2012

thx

@ghost ghost added a commit that referenced this pull request Sep 13, 2012

Arne Morten Kvarving Merge pull request #1417 from fetzerch/feature-exif-charset
[libexif] Added character set conversion to UserComment
cf7144f

@ghost ghost merged commit cf7144f into xbmc:master Sep 13, 2012

This issue was closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment