Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cleanup] silence casts away qualifiers warnings #14192

merged 18 commits into from Jul 21, 2018


Copy link

commented Jul 17, 2018

How Has This Been Tested?

compiled with "-Werror=cast-qual for android, ios, linux and osx

Types of change

  • Bug fix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves existing functionality)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Cosmetic change (non-breaking change that doesn't touch code)
  • None of the above (please explain below)


  • My code follows the Code Guidelines of this project
  • My change requires a change to the documentation, either Doxygen or wiki
  • I have updated the documentation accordingly
  • I have read the Contributing document
  • I have added tests to cover my change
  • All new and existing tests passed

@Rechi Rechi requested a review from FernetMenta Jul 17, 2018

static void* GUILib_RegisterMe (void* addonData);
static void GUILib_UnRegisterMe (void* addonData, void* cbTable);
void* GUILib_GetHelper() { return m_helperGUI; }
void* GUILib_GetHelper() const { return m_helperGUI; }

This comment has been minimized.

Copy link

Rechi Jul 17, 2018

Author Member

does this change binary addons ABI?

@Rechi Rechi force-pushed the Rechi:cleanup/warnings branch 5 times, most recently from 9759aef to aebea1d Jul 18, 2018

@Rechi Rechi force-pushed the Rechi:cleanup/warnings branch from aebea1d to 9e0fc73 Jul 21, 2018

@Rechi Rechi added this to the Leia 18.0-alpha3 milestone Jul 21, 2018

@Rechi Rechi merged commit 0b8f23a into xbmc:master Jul 21, 2018

1 check passed

default You're awesome. Have a cookie

@Rechi Rechi deleted the Rechi:cleanup/warnings branch Jul 21, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
2 participants
You can’t perform that action at this time.