[PVR] Stop only active instant recording #1423

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
3 participants
Contributor

BluTuTh commented Sep 14, 2012

Currently all timers on channel are deleted if you stop active instant recording with XBMC.PlayerControl(record). There is also no notification.

With this fix only active recording on current channel is stopped. Any possible future timers on channel are not deleted.
Notification now works correctly.
PVR.IsRecording didn't return correct status when recording was stopped with XBMC.PlayerControl(record), now this is fixed.

Contributor

mikrohard commented Sep 14, 2012

This code would work for Eden... but you need to change it for Frodo...

Change this:
vector<CPVRTimerInfoTag *> activeTags; m_timers->GetActiveRecordings(&activeTags);
Into this:
vector<CFileItemPtr> activeTags = g_PVRTimers->GetActiveRecordings();

Change this:
CPVRTimerInfoTag *timer = activeTags.at(pat);
Into this:
CFileItemPtr timer = activeTags.at(pat);

And this:
if (timer->m_iClientChannelUid == channel.UniqueID())
Into this:
if (timer->GetPVRTimerInfoTag()->m_iClientChannelUid == channel->UniqueID())

Member

opdenkamp commented Sep 26, 2012

@BluTuTh could you update this PR please

@BluTuTh BluTuTh Stop only active instant recording
Currently all timers on channel are deleted if you stop active instant recording with XBMC.PlayerControl(record). There is also no notification.

With this fix only active recording on current channel is stopped. Any possible future timers on channel are not deleted.
0cedca1
Contributor

BluTuTh commented Sep 26, 2012

PR is now updated.
Thanks to mikrohard for help.

I noticed that in Frodo PVR.IsRecording stays TRUE, even after DeleteTimer() is executed.
It seens like the problem is somewhere deeper, probably in PVR client. I will try to fix it.

Member

opdenkamp commented Sep 26, 2012

DeleteTimer() doesn't delete the timer. it sends the command to the server, which in turn deletes the timer, which then updates the state in xbmc.

opdenkamp was assigned Oct 2, 2012

Member

opdenkamp commented Oct 3, 2012

isn't this code doing exactly what the call to DeleteTimersOnChannel() is already doing? or supposed to be doing?

Member

opdenkamp commented Oct 10, 2012

right, i'm closing this one. if CPVRTimers::DeleteTimersOnChannel() isn't doing what it should be doing (with the third parameter set to true), then that needs fixing

opdenkamp closed this Oct 10, 2012

@LongChair LongChair added a commit to plexinc/plex-home-theater-public that referenced this pull request Nov 27, 2014

@LongChair LongChair Fix Enter behavior in PQWindow. fixes #1423 4eefa2b

@LongChair LongChair added a commit to plexinc/plex-home-theater-public that referenced this pull request Nov 27, 2014

@LongChair LongChair Better Fix for Enter behavior in Watched Items #1423
Previous patch would fix the item being played, although it would play only the item and not move on with the PQ.

Regarding this patch, it seems that local PQ were not matching start item on video items, but only on audio, it's working fine on video as well.
ff8ae16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment