Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VideoPlayer: frame advance - fix + infobool #14230

Merged
merged 2 commits into from Jul 29, 2018

Conversation

@FernetMenta
Copy link
Member

commented Jul 26, 2018

  • fixes frame advance
  • adds infobool: showing seekbar during frame advance is not desired
@ksooo
Copy link
Member

left a comment

just a comment re guiinfo

@@ -528,6 +528,9 @@ bool CPlayerGUIInfo::GetBool(bool& value, const CGUIListItem *gitem, int context
case PLAYER_HASDURATION:
value = g_application.GetTotalTime() > 0;
return true;
case PLAYER_FRAMEADVANCE:

This comment has been minimized.

Copy link
@ksooo

ksooo Jul 26, 2018

Member

To get this working you need to extend the guiinfomanager player_labels infomap: https://github.com/xbmc/xbmc/blob/master/xbmc/GUIInfoManager.cpp#L398

And please don't forget to add doxy for the new infobool above the map.

And it would be even more nice (though unrelated) if you could add doxy for the last few bools/labels you've added in recent PRs. It seems that we forgot to add doxy for those new labels/bools- namely for:

{ "tempoenabled", PLAYER_SUPPORTS_TEMPO},
{ "istempo", PLAYER_IS_TEMPO},
{ "playspeed", PLAYER_PLAYSPEED},
{ "hasprograms", PLAYER_HAS_PROGRAMS},
{ "hasresolutions", PLAYER_HAS_RESOLUTIONS}

This comment has been minimized.

Copy link
@enen92

enen92 Jul 27, 2018

Member

Please also add the wiki-needed label so we can track what needs to be added there

This comment has been minimized.

Copy link
@FernetMenta

FernetMenta Jul 27, 2018

Author Member

To get this working you need to extend the guiinfomanager player_labels infomap:

this is part of the PR

@FernetMenta FernetMenta force-pushed the FernetMenta:advance branch from 9c5c85e to ae704f3 Jul 27, 2018

@FernetMenta

This comment has been minimized.

Copy link
Member Author

commented Jul 29, 2018

label and doxy added

@FernetMenta FernetMenta merged commit 2d2fbfd into xbmc:master Jul 29, 2018

1 check passed

default You're awesome. Have a cookie
Details

@FernetMenta FernetMenta deleted the FernetMenta:advance branch Jul 29, 2018

@Rechi Rechi added this to the Leia 18.0-alpha3 milestone Jul 29, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.