Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[guiinfo] Fix PLAYER_(PATH|FILENAME|FILEPATH). #14239

Merged
merged 1 commit into from Jul 31, 2018

Conversation

@ksooo
Copy link
Member

commented Jul 29, 2018

Fixes a regression reported in the forum: https://forum.kodi.tv/showthread.php?tid=330696&pid=2755039#pid2755039

Runtime-tested with latest kodi master on macOS.

@@ -175,6 +176,26 @@ CGUIListItemPtr GetCurrentListItem(int contextWindow, int containerId /* = 0 */,
return item;
}

std::string GetFileInfoLabelFromItem(int info, const CFileItem *item)

This comment has been minimized.

Copy link
@Rechi

Rechi Jul 29, 2018

Member

Why pass CFileItem by pointer instead of passing it by reference?

This comment has been minimized.

Copy link
@ksooo

ksooo Jul 29, 2018

Author Member

Because all of the guiinfo API functions are using raw pointers. So, reason could be consistency. But no hard feelings about that. Do you want me to change this?

This comment has been minimized.

Copy link
@Rechi

Rechi Jul 29, 2018

Member

You can keep it as is, just wondered why passing by pointer and then there is no nullptr check.

@ksooo ksooo force-pushed the ksooo:guiinfo-fix-player-path branch from cb5d9a1 to 534650b Jul 30, 2018

@ksooo ksooo force-pushed the ksooo:guiinfo-fix-player-path branch from 534650b to 556a07b Jul 30, 2018

@ksooo ksooo merged commit 269a24c into xbmc:master Jul 31, 2018

1 check passed

default You're awesome. Have a cookie
Details

@ksooo ksooo deleted the ksooo:guiinfo-fix-player-path branch Jul 31, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.