toggles an add-on enabled/disabled
@vdrfan updated after our chat on irc
added ToggleAddonEnabled to CBuiltins, to enable/disable an add-on (t…
enable/disable service add-ons and restart the pvr manager if needed …
…in a new method CAddonMgr::DisableAddon(), instead of in the add-on db or cbuiltins
also restart the epg updater when enabling/disabling a pvr add-on
could someone sign off on this one
What is the point of the builtin exactly? i.e. why do we need the builtin - who is calling it, and why exactly?
I'd reorder the commits as well so the enable/disable one is done first c4e6d86/43a48b5, which could be squashed, and then 4803228 (if deemed needed) on top.
I really don't like the includes of the PVR globals within AddonMgr though. It shouldn't need to know specifics about addons - ideally these would be handled instead with some sort of addon::ondisabled() or some such to isolate things.
i can use it to enable/disable an add-on via the event server, easier for me when i'm testing on a system without a keyboard or remote connected. didn't see anything to do this with 1 command from the cmdline, so i added this one.
will reorder and squashing before pushing.
i'll have a look at some ondisabled() to do this.
JSON-RPC will soon allow you to enable/disable (no toggle right now but could be added) an addon (just haven't merged the PR yet).
right ok, then i'll remove the builtin and only fix the pvrmanager reset
As an FYI I've merged the PR containing the Addons.SetAddonEnabled JSON-RPC method and I added a "toggle" functionality for easier use.
Does it make sense to drop the first commit, adjust the second one and then merge those two commits?
i'll just drop this PR completely and just push the fix when i've written it