Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

d-r: enable dirty-regions by default #1426

Merged
merged 1 commit into from

1 participant

Cory Fields
Cory Fields
Owner

As decided at devcon. Enable dirty-regions by default on all platforms.

This enables the all-or-nothing mode, which means that we repaint the entire
screen if there's a single dirty region.

Also, nofliptimeout=0 is set to ensure that we never flip without rendering.

With these combined, this should be universally safe (and within spec) for all
gfx cards/drivers.

The main possible side-effect is the slow-motion effect brought about on slower
cpus that can't keep up at times and produce wild timestamps. With our improved
decoding and caching, this is now quite rare.

Cory Fields d-r: enable dirty-regions by default
This enables the all-or-nothing mode, which means that we repaint the entire
screen if there's a single dirty region.

Also, nofliptimeout=0 is set to ensure that we never flip without rendering.

With these combined, this should be universally safe (and within spec) for all
gfx cards/drivers.

The main possible side-effect is the slow-motion effect brought about on slower
cpus that can't keep up at times and produce wild timestamps. With our improved
decoding and caching, this is now quite rare.
735e49e
Cory Fields theuni was assigned
Cory Fields theuni merged commit 1915f25 into from
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Commits on Sep 14, 2012
  1. d-r: enable dirty-regions by default

    Cory Fields authored
    This enables the all-or-nothing mode, which means that we repaint the entire
    screen if there's a single dirty region.
    
    Also, nofliptimeout=0 is set to ensure that we never flip without rendering.
    
    With these combined, this should be universally safe (and within spec) for all
    gfx cards/drivers.
    
    The main possible side-effect is the slow-motion effect brought about on slower
    cpus that can't keep up at times and produce wild timestamps. With our improved
    decoding and caching, this is now quite rare.
This page is out of date. Refresh to see the latest.
Showing with 2 additions and 2 deletions.
  1. +2 −2 xbmc/settings/AdvancedSettings.cpp
4 xbmc/settings/AdvancedSettings.cpp
View
@@ -306,8 +306,8 @@ void CAdvancedSettings::Initialize()
m_canWindowed = true;
m_guiVisualizeDirtyRegions = false;
- m_guiAlgorithmDirtyRegions = 0;
- m_guiDirtyRegionNoFlipTimeout = -1;
+ m_guiAlgorithmDirtyRegions = 3;
+ m_guiDirtyRegionNoFlipTimeout = 0;
m_logEnableAirtunes = false;
m_airTunesPort = 36666;
m_airPlayPort = 36667;
Something went wrong with that request. Please try again.