Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VideoPlayer: fixup flush after cdd5417611ddce737fef6008a6a67ebad84be67a #14260

Merged
merged 1 commit into from Aug 3, 2018

Conversation

@FernetMenta
Copy link
Member

commented Aug 3, 2018

see title

@FernetMenta FernetMenta force-pushed the FernetMenta:flush branch from ce95661 to 91d0e16 Aug 3, 2018

@FernetMenta FernetMenta changed the title VideoPlayer: fixup flsuh after cdd5417611ddce737fef6008a6a67ebad84be67a VideoPlayer: fixup flush after cdd5417611ddce737fef6008a6a67ebad84be67a Aug 3, 2018

@Rechi Rechi added this to the Leia 18.0-beta1 milestone Aug 3, 2018

@FernetMenta FernetMenta merged commit 0c85b56 into xbmc:master Aug 3, 2018

1 check passed

default You're awesome. Have a cookie
Details

@FernetMenta FernetMenta deleted the FernetMenta:flush branch Aug 3, 2018

@boot2k3

This comment has been minimized.

Copy link
Contributor

commented Aug 3, 2018

This change broke AML in CVideoPlayer::OnLostDisplay() again. After cdd5417 it was fixed.

@FernetMenta

This comment has been minimized.

Copy link
Member Author

commented Aug 3, 2018

get lost. CoreElec members are not welcome here

@FernetMenta

This comment has been minimized.

Copy link
Member Author

commented Aug 3, 2018

I quote Adam Green @adamg88

Why is that? Because we always point out how your shitty PRs always break something?

If you say my PRs are shitty, you also say that entire video player and audio engine are shitty. Why don't you write your own player instead of just raping our code.

@xbmc xbmc locked as too heated and limited conversation to collaborators Aug 3, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
3 participants
You can’t perform that action at this time.