Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Coverity fixes #14273

Merged
merged 1 commit into from Aug 7, 2018

Conversation

Projects
None yet
3 participants
@DaveTBlake
Copy link
Member

commented Aug 7, 2018

Clean up a few things from the Coverity report in the music library code

@notspiff

This comment has been minimized.

Copy link
Contributor

commented Aug 7, 2018

looks fine.

@@ -319,6 +319,7 @@ CGUIDialogMusicInfo::CGUIDialogMusicInfo(void)
m_hasUpdatedUserrating = false;
m_hasRefreshed = false;
m_bArtistInfo = false;
m_scraperAddInfo = false;

This comment has been minimized.

Copy link
@Rechi

Rechi Aug 7, 2018

Member

use default member initializer

This comment has been minimized.

Copy link
@DaveTBlake

DaveTBlake Aug 7, 2018

Author Member

But will that set all these members as required e.g. make new CFileItemList and clear string?

This comment has been minimized.

Copy link
@Rechi

Rechi Aug 7, 2018

Member

I'm only asking to do it for the one variable you added now and yes this constructor is still called.

This comment has been minimized.

Copy link
@DaveTBlake

DaveTBlake Aug 7, 2018

Author Member

I don't see how doing this one variable (that was previously overlooked by accident) differently to the rest makes better/clearer code.

This comment has been minimized.

Copy link
@DaveTBlake

DaveTBlake Aug 7, 2018

Author Member

Ah OK, this got missed from global change to defaut member initializers. I will do all bools

@DaveTBlake DaveTBlake force-pushed the DaveTBlake:coverityfix branch from bb38eb0 to 8c61c24 Aug 7, 2018

@@ -316,10 +316,6 @@ CGUIDialogMusicInfo::CGUIDialogMusicInfo(void)
m_albumSongs = new CFileItemList;
m_loadType = KEEP_IN_MEMORY;
m_startUserrating = -1;

This comment has been minimized.

Copy link
@notspiff

notspiff Aug 7, 2018

Contributor

remove.

This comment has been minimized.

Copy link
@DaveTBlake

DaveTBlake Aug 7, 2018

Author Member

Doh, commited without save!

@DaveTBlake DaveTBlake force-pushed the DaveTBlake:coverityfix branch from 8c61c24 to 1be884c Aug 7, 2018

@DaveTBlake DaveTBlake force-pushed the DaveTBlake:coverityfix branch from 1be884c to 737356b Aug 7, 2018

@DaveTBlake

This comment has been minimized.

Copy link
Member Author

commented Aug 7, 2018

jenkins build this please

@DaveTBlake DaveTBlake merged commit 164db1c into xbmc:master Aug 7, 2018

1 check passed

default You're awesome. Have a cookie
Details

@DaveTBlake DaveTBlake deleted the DaveTBlake:coverityfix branch Aug 7, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.