Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VideoPlayer: add audiosetting for downmix clev #14326

Merged
merged 1 commit into from Aug 20, 2018

Conversation

Projects
None yet
6 participants
@FernetMenta
Copy link
Member

commented Aug 20, 2018

see title

msgid "Downmix: Center Mix Level"
msgstr ""

#: xbmc/video/dialogs/GUIDialogAudioSettings.cpp

This comment has been minimized.

Copy link
@ksooo

ksooo Aug 20, 2018

Member

Could you please add a comment (#. bla bla) explaining in plain language what the new strings are used for. This really helps translators to find a good translation.

This comment has been minimized.

Copy link
@FernetMenta

FernetMenta Aug 20, 2018

Author Member

any suggestion? imo this is self explanatory and does not need further explanation provided s.o. is familiar with downmixing. this is not the right place to explain technology.

This comment has been minimized.

Copy link
@ksooo

ksooo Aug 20, 2018

Member

provided s.o. is familiar with downmixing. this is not the right place to explain technology.

We cannot assume that a translator is familar with all technology used in Kodi. That's exactly why some explanatory words are of big value here. I think you don't need to explain the whole technology, but if you want high quality translations, some guiding words do not harm.

This comment has been minimized.

Copy link
@FernetMenta

FernetMenta Aug 20, 2018

Author Member

I won't add the obvious here. if s.o. does not know what downmix is, 1-2 sentences won't be enough to explain.

If you come up with suggestions, we can discuss it.

This comment has been minimized.

Copy link
@notspiff

notspiff Aug 20, 2018

Contributor

my suggestion for a comment would be 'Used for a setting which allows to increase the weight given to the center channel when downmixing. Typically used to boost voice levels.'

This comment has been minimized.

Copy link
@FernetMenta

FernetMenta Aug 20, 2018

Author Member

thanks, added


#: xbmc/video/dialogs/GUIDialogAudioSettings.cpp
msgctxt "#39113"
msgid "Center Mix Level in DB relative to metadata or default (-3 dB)"

This comment has been minimized.

Copy link
@ksooo

ksooo Aug 20, 2018

Member

"DB" => "dB"

@FernetMenta FernetMenta force-pushed the FernetMenta:downmix branch from 1c637b7 to 3bff8d1 Aug 20, 2018

@FernetMenta FernetMenta force-pushed the FernetMenta:downmix branch from 3bff8d1 to 2fe7d9d Aug 20, 2018

@FernetMenta FernetMenta merged commit 1b7e29a into xbmc:master Aug 20, 2018

1 check passed

default You're awesome. Have a cookie
Details

@FernetMenta FernetMenta deleted the FernetMenta:downmix branch Aug 20, 2018

@Rechi Rechi referenced this pull request Aug 20, 2018

Closed

Boost center channel #14011

@zag2me

This comment has been minimized.

Copy link
Contributor

commented Aug 21, 2018

Thank you! Tested and working as expected on Android Shield. Improvement for the majority of Kodi users without configurable 5.1 setups, now we don't need to watch movies on a raspberry pi or SPMC builds 👍

+25db seems about right for me on my soundbar. For anyone needing to find this: Its in OSD >> Settings >> Audio Settings >> "Downmix: Center Mix Level".

@FernetMenta

This comment has been minimized.

Copy link
Member Author

commented Aug 21, 2018

If you have to increase clev by 25dB there is certainly a problem with your system. btw: most of the time I use a 2.0 setup too and never felt the need to boost center channel.

25dB sounds like crappy Android or Shield wires sides or backs as FL/FR.

@fritsch

This comment has been minimized.

Copy link
Member

commented Aug 22, 2018

@FernetMenta

This comment has been minimized.

Copy link
Member Author

commented Aug 22, 2018

screen shot 2018-08-22 at 07 23 21

@fritsch the setting is computed correctly

@MartijnKaijser MartijnKaijser added this to the Leia 18.0-beta1 milestone Aug 26, 2018

@zag2me

This comment has been minimized.

Copy link
Contributor

commented Sep 6, 2018

Reported a few times that this setting does not "stick".

https://forum.kodi.tv/showthread.php?tid=334664&pid=2761012#pid2761012

@FernetMenta

This comment has been minimized.

Copy link
Member Author

commented Sep 6, 2018

The setting is stored like other video settings with the file

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.