Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GLES logging cleanup and unused extension removal #14384

Merged
merged 3 commits into from Sep 3, 2018

Conversation

@lrusak
Copy link
Contributor

commented Sep 2, 2018

Cleans up much of the unneeded log spam and makes the logging more uniform.

lrusak added 3 commits Sep 2, 2018
RenderSystemGLES: remove logging of extension test
This isn't needed at all as it's already logged in the GL_EXTENSIONS and just contributes to log spam

@lrusak lrusak added this to the Leia 18.0-beta2 milestone Sep 2, 2018

@lrusak lrusak requested review from FernetMenta and Memphiz Sep 2, 2018

@Memphiz
Memphiz approved these changes Sep 2, 2018
Copy link
Member

left a comment

As the log about extension test is removed in that PR and this was the spammy entry i mentioned i am very ok with this :)

@@ -183,26 +183,14 @@ bool CRenderSystemGLES::IsExtSupported(const char* extension) const
// GLES has FBO as a core element, not an extension!
return true;
}
else if (strcmp( extension, "GL_TEXTURE_NPOT" ) == 0)

This comment has been minimized.

Copy link
@FernetMenta

FernetMenta Sep 2, 2018

Member

Are you sure this case is covered by the else block?

This comment has been minimized.

Copy link
@lrusak

lrusak Sep 3, 2018

Author Contributor

a quick grep of the code doesn't show that we explicitly check for GL_TEXTURE_NPOT anywhere

@lrusak lrusak merged commit 5d7e1db into xbmc:master Sep 3, 2018

1 check passed

default You're awesome. Have a cookie
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.