libid3tag dependency and remove libid3tag and libapetag #1450

Merged
merged 2 commits into from Oct 5, 2012

Conversation

Projects
None yet
4 participants
Contributor

night199uk commented Sep 20, 2012

This PR changes the CDRipper for MP3s to just use Lame's internal functions for writing ID3 tags. This gets round the smbc_ftruncate problem with tag lib for now, and allows us to remove libid3tag more quickly.

I'm working on TagLib write support separately as I need to fix up MusicInfoTag anyway.

Thanks theuni for the Linux/Android parts.

Contributor

night199uk commented Sep 20, 2012

@wsoltys Can you review this for the Windows dependencies please?

Contributor

night199uk commented Sep 20, 2012

@Fneufneu any fbsd dependencies, too?

Owner

Montellese commented Sep 20, 2012

I updated the Visual Studio solution by removing the libid3tag projects and the deleted files. Furthermore there is one additional fix necessary in cddb.cpp which is not win32 specific (which is why I put it in a seperate commit so you can squash it into your other commits). You can grab the two commits from Montellese/xbmc@master...taglib

Contributor

night199uk commented Sep 21, 2012

Thanks Montellese, I integrated your changes into this PR.

Contributor

night199uk commented Sep 21, 2012

@huceke anything needed here for rbpi?

Member

Fneufneu commented Sep 21, 2012

good for me

@ghost ghost assigned theuni Oct 1, 2012

@ghost

ghost commented Oct 2, 2012

rebase and pull?

Contributor

night199uk commented Oct 3, 2012

I'm back in town on Friday and will rebase and pull over this weekend, unless someone else is bored and fancies doing it :-) Currently in the Philippines with little internet. Should be done on Sat morning I reckon.

On 3 Oct 2012, at 02:15, Arne Morten Kvarving wrote:

rebase and pull?


Reply to this email directly or view it on GitHub.

night199uk and others added some commits Sep 20, 2012

[lame] Change LameEncoder to use internal lame tagger, replicating cu…
…rrent CDRip tagging. Removes dependency on libid3tag.
libid3tag/libapetag win/mac/linux/android removal (thanks theuni for …
…the linux/android parts and montellese for win32)

night199uk added a commit that referenced this pull request Oct 5, 2012

Merge pull request #1450 from night199uk/taglib
libid3tag dependency and remove libid3tag and libapetag

@night199uk night199uk merged commit 952e305 into xbmc:master Oct 5, 2012

LongChair added a commit to plexinc/plex-home-theater-public that referenced this pull request Feb 5, 2015

Complete User Selection dialog refactoring, part of #1450
This completes the replacement of the startup window and doesnt use anymore dialogs. Should help getting #1450 further fixed

LongChair added a commit to plexinc/plex-home-theater-public that referenced this pull request Feb 5, 2015

LongChair added a commit to plexinc/plex-home-theater-public that referenced this pull request Feb 5, 2015

LongChair added a commit to plexinc/plex-home-theater-public that referenced this pull request Feb 5, 2015

LongChair added a commit to plexinc/plex-home-theater-public that referenced this pull request Feb 5, 2015

LongChair added a commit to plexinc/plex-home-theater-public that referenced this pull request Feb 5, 2015

LongChair added a commit to plexinc/plex-home-theater-public that referenced this pull request Feb 5, 2015

LongChair added a commit to plexinc/plex-home-theater-public that referenced this pull request Feb 5, 2015

LongChair added a commit to plexinc/plex-home-theater-public that referenced this pull request Feb 5, 2015

LongChair added a commit to plexinc/plex-home-theater-public that referenced this pull request Feb 5, 2015

LongChair added a commit to plexinc/plex-home-theater-public that referenced this pull request Feb 5, 2015

LongChair added a commit to plexinc/plex-home-theater-public that referenced this pull request Feb 5, 2015

LongChair added a commit to plexinc/plex-home-theater-public that referenced this pull request Feb 5, 2015

LongChair added a commit to plexinc/plex-home-theater-public that referenced this pull request Feb 5, 2015

LongChair added a commit to plexinc/plex-home-theater-public that referenced this pull request Feb 5, 2015

LongChair added a commit to plexinc/plex-home-theater-public that referenced this pull request Feb 5, 2015

Make sure we don't leave any active job, when exiting users window, p…
…art of #1450

When playing a flinged PQ from companion on locked screen, between PQ items, the Fullscreenwindow is closed, we return instantly to Users Window, and restart the full screen window again.

In That siatuation, the users fecth job is swpaned and will complete once the window has been uninitialized, causing a crash.

This patch ensures that we cancel the job if there is any, before uniniting the users window.

LongChair added a commit to plexinc/plex-home-theater-public that referenced this pull request Feb 5, 2015

LongChair added a commit to plexinc/plex-home-theater-public that referenced this pull request Feb 5, 2015

LongChair added a commit to plexinc/plex-home-theater-public that referenced this pull request Feb 5, 2015

LongChair added a commit to plexinc/plex-home-theater-public that referenced this pull request Feb 5, 2015

LongChair added a commit to plexinc/plex-home-theater-public that referenced this pull request Apr 30, 2015

Get ListItem.isSelected updated in users list, part of #1450
That allows to show the proper checkbox which shows the currently selected user.

LongChair added a commit to plexinc/plex-home-theater-public that referenced this pull request Apr 30, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment