[Feature][skin.estuary] add support for artist-slideshow add-on #14558
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
da-anda
added
Type: Feature
Rechi
reviewed
Oct 9, 2018
| #: /xml/SkinSettings.xml | ||
| msgctxt "#31167" | ||
| msgid "Animate background" | ||
| msgstr "" |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
ronie
reviewed
Oct 9, 2018
| <fadetime>400</fadetime> | ||
| <animation effect="fade" start="0" end="100" time="400">WindowOpen</animation> | ||
| <animation effect="fade" start="100" end="0" time="300">WindowClose</animation> | ||
| <texture background="true" colordiffuse="88FFFFFF">$INFO[Player.Art(fanart)]</texture> |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
da-anda
force-pushed
the
estuary-slideshow
branch
from
65beb3d
to
b5040db
Compare
da-anda
force-pushed
the
estuary-slideshow
branch
from
b5040db
to
4516a01
Compare
|
addressed both comments |
|
any objections to merge or other things I should change? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This adds support for the artistslideshow add-on in case it got installed by the users. It's no requirement or anything, just calls it when it's installed.
I also added a new setting to the MusicOSD settings that allows to animate the background (pan and zoom animation).
Motivation and Context
Had written a PR for it a year or more ago against phils repo which was considered "upstream" back then, but it never got merged. And since I miss it, I thought I give it another try.
How Has This Been Tested?
Tested on Windows
Types of change
Checklist: