Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
Fix for embedded PGS Subtitles #1458
This fixes the issue described in ticket #12074 which leads to PGS Subtitles only flashing up for one or 2 frames.
This PR backports a needed fix in ffmpeg for this and also adapts the CDVDOverlayCodecFFmpeg for fullfilling some assumptions made by ffmpeg.
There was a small refactor needed too in the DVDOverlayCodecs:
Basically behaviour shouldn't be changed by this for the overlay decoders. Only for the PGS case when using the CDVDOverlayCodecFFmpeg was altered (though it might be valid to do these changes in general - not only for PGS).
The analysis of the problem can be found here:
@elupus please comment/review. This might finally close a 1 year old bug ;)
I'm not quiet sure about the used time_base here (DVD_TIME_BASE). I thought packet pts was always using the stream time_base. I have tried that too (just by hardcoding it to num = 1 and den = 900000) - but this leads to async subs.