Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DVDVideoCodecAndroidMediaCodec: Revert c15ff2d9f6e - to accelerate dvds #14662

Merged
merged 1 commit into from Oct 26, 2018

Conversation

@fritsch
Copy link
Member

commented Oct 21, 2018

Happy regression testing. Was demanded by users here: https://forum.kodi.tv/showthread.php?tid=332945&page=4

From technical pov stills and dvds are nowadays a solved problem on most platforms. Let's see how we regress.

@fritsch fritsch requested a review from peak3d Oct 21, 2018
@peak3d
peak3d approved these changes Oct 21, 2018
@MartijnKaijser

This comment has been minimized.

Copy link
Member

commented Oct 21, 2018

Can the commit message be extended a bit with why?

@fritsch fritsch force-pushed the fritsch:dvdandroid branch from ed6ba2b to 71516d8 Oct 21, 2018
@fritsch

This comment has been minimized.

Copy link
Member Author

commented Oct 21, 2018

Extended commit message.

@fritsch fritsch force-pushed the fritsch:dvdandroid branch from 71516d8 to a81ef14 Oct 21, 2018
This restores acceleration for DVDs. It was originally disabled, because someone had issues with something (not documented). As no one wanted to track down the real issue - a quick hack was chosen. Since then users screamed on regularly basis until it was reenabled again. Let's see which errors come up this time.
@fritsch fritsch force-pushed the fritsch:dvdandroid branch from a81ef14 to 17dc0bc Oct 21, 2018
@MartijnKaijser

This comment has been minimized.

Copy link
Member

commented Oct 22, 2018

Jenkins build this please

@fritsch

This comment has been minimized.

Copy link
Member Author

commented Oct 22, 2018

Please wait until: https://forum.kodi.tv/showthread.php?tid=332945&pid=2784941#pid2784941 got some replies. We know that we will hit issues.

@fritsch fritsch added the Don't merge label Oct 22, 2018
@fritsch

This comment has been minimized.

Copy link
Member Author

commented Oct 23, 2018

Closed: https://forum.kodi.tv/showthread.php?tid=332945&pid=2785126#pid2785126

RM is right. Fixing it correctly or not at all.

@fritsch fritsch closed this Oct 23, 2018
@MartijnKaijser MartijnKaijser added v18 Leia and removed Don't merge labels Oct 26, 2018
@MartijnKaijser MartijnKaijser added this to the Leia 18.0-beta5 milestone Oct 26, 2018
@MartijnKaijser

This comment has been minimized.

Copy link
Member

commented Oct 26, 2018

jenkins build this please

@peak3d

This comment has been minimized.

Copy link
Contributor

commented Oct 26, 2018

After internal team discussion we decided to merge this and analyze related issues if users run into them.

@MartijnKaijser MartijnKaijser merged commit 0d205b0 into xbmc:master Oct 26, 2018
1 check was pending
1 check was pending
default Yeah yeah I'll start on it when I get some time.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.