Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix crash on exit when checking of libgpg-error lock object size. #14683

Merged
merged 1 commit into from Oct 24, 2018

Conversation

@srg70
Copy link

commented Oct 23, 2018

Description

iOS/tvOS platform related. This PR patches a makefile of libgpg-error project to make the size of lib's lock object fits native mutex.

It may be done by choosing the "right" header file from lib's repository. Just before building of the project, it copies pre-created (by project maintainer) header file for aarch64-apple-darwin architecture, over the file for "our" build architecture arm-apple-darwin.

Motivation and Context

Every time when you exit Kodi on iOS/tvOS platform, the application crashes in posse-lock.c file on assertion
if (sizeof (gpgrt_lock_t) < sizeof (_gpgrt_lock_t)) { assert (!"sizeof lock obj"); abort (); }

How Has This Been Tested?

Run and exit from application under debugger. Before changes debugger stops on assert() call. After applying of PR you should not see this code anymore.

Screenshots (if appropriate):

Types of change

  • Bug fix (non-breaking change which fixes an issue)
  • Clean up (non-breaking change which removes non-working, unmaintained functionality)
  • Improvement (non-breaking change which improves existing functionality)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that will cause existing functionality to change)
  • Cosmetic change (non-breaking change that doesn't touch code)
  • None of the above (please explain below)

Checklist:

  • My code follows the Code Guidelines of this project
  • My change requires a change to the documentation, either Doxygen or wiki
  • I have updated the documentation accordingly
  • I have read the Contributing document
  • I have added tests to cover my change
  • All new and existing tests passed
@MartijnKaijser MartijnKaijser requested a review from Memphiz Oct 23, 2018
Copy link
Member

left a comment

works like a charme. Good catch. Thx for the fix :)

@Memphiz Memphiz merged commit 118ba40 into xbmc:master Oct 24, 2018
1 check passed
1 check passed
default You're awesome. Have a cookie
Details
@Rechi Rechi added this to the Leia 18.0-beta5 milestone Oct 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.