Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Android] switch renderGUI based on surface existance instead onPause/onSuspend #14686

Merged
merged 1 commit into from Oct 23, 2018

Conversation

@peak3d
Copy link
Contributor

commented Oct 23, 2018

Description

Stop rendering GUI if surface is destroyed / start rendering GUI after surface is created.
This handling was before incorrectly handled in onPause / onResume.

Motivation and Context

  • Fix eglSwapBuffer exceptions (kodi termination)
  • Reenable VisibleBehind (for Android < O

How Has This Been Tested?

Press Home button, navigate back to kodi on:

  • Shield TV 2017 (video is paused)
  • WETEK Hub (video plays in background)

Types of change

  • Bug fix (non-breaking change which fixes an issue)
  • Clean up (non-breaking change which removes non-working, unmaintained functionality)
  • Improvement (non-breaking change which improves existing functionality)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that will cause existing functionality to change)
  • Cosmetic change (non-breaking change that doesn't touch code)
  • None of the above (please explain below)
@CiNcH83

This comment has been minimized.

Copy link

commented Oct 23, 2018

Looks good. VisibleBehind and TV menus work again without "pausing" video on Sony ATV with Android TV Nougat.

@peak3d peak3d merged commit 03b0877 into xbmc:master Oct 23, 2018

1 check passed

default You're awesome. Have a cookie
Details

@peak3d peak3d deleted the peak3d:rendergui branch Oct 23, 2018

@CiNcH83 CiNcH83 referenced this pull request Oct 23, 2018
1 of 1 task complete
@@ -90,7 +90,7 @@ void CWinSystemAndroidGLESContext::PresentRenderImpl(bool rendered)
{
// Ignore EGL_BAD_SURFACE: It seems to happen during/after mode changes, but

This comment has been minimized.

Copy link
@CiNcH83

CiNcH83 Oct 23, 2018

Remove comment?

This comment has been minimized.

Copy link
@peak3d

peak3d Oct 24, 2018

Author Contributor

thx, will remove in next PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.