Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FullscreenGame: Remove OSD toggle action #14691

Merged
merged 1 commit into from Oct 24, 2018

Conversation

@garbear
Copy link
Member

commented Oct 23, 2018

This PR is a simple one. We'll never need to close the OSD from the fullscreen game window, because the fullscreen game window can only receive the toggle action if the OSD is already closed.

Motivation and Context

Reduction of unreachable code.

How Has This Been Tested?

Code was unreachable, so this shouldn't have any effect. I confirmed that the OSD can still be opened from the fullscreen game window.

Types of change

  • Bug fix (non-breaking change which fixes an issue)
  • Clean up (non-breaking change which removes non-working, unmaintained functionality)
  • Improvement (non-breaking change which improves existing functionality)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that will cause existing functionality to change)
  • Cosmetic change (non-breaking change that doesn't touch code)
  • None of the above (please explain below)
We'll never need to close the OSD from the fullscreen game window, because
the fullscreen game window can only receive the toggle action if the OSD is
already closed.
@garbear garbear merged commit 1ce3b09 into xbmc:master Oct 24, 2018
1 check passed
1 check passed
default You're awesome. Have a cookie
Details
@garbear garbear deleted the garbear:remove-toggle branch Oct 24, 2018
@Rechi Rechi added this to the Leia 18.0-beta5 milestone Oct 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.