[cmake/Xcode] - fix missing text and icon resources when using target Xcode #14693
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Memphiz
added
Type: Fix
Rechi
reviewed
Oct 23, 2018
cmake/scripts/ios/Install.cmake
Outdated
| else() | ||
| set(RESOURCE_LOCATION ".") | ||
| endif() | ||
| set(RESOURCE_LOCATION ".") |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
Memphiz
force-pushed
the
fix_xcode_resources
branch
from
4bd0f62
to
f45b0fa
Compare
|
changed |
Rechi
approved these changes
Oct 23, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using Xcode as cmake generator the launch images, app icons and text resources were placed into Kodi.app/Kodi.app instead of Kodi.app.
Not sure if this changed with recent Xcode versions or not - but it resulted in broken app bundle when using Xcode.
Jenkins uses make generator and was not affected.