[libcmyth/refmem] Pull across upstream changes to support other architec... #1471

Closed
wants to merge 1 commit into
from

6 participants

@dteirney
Team Kodi member

...tures.

RFC: This PR contains a number of updates from upstream for the refmem bits within the cmyth library. I'm not familiar with this area much so this is really an exercise to try and get XBMC and upstream in sync. I've reviewed the diffs and made the changes to both sides that seem sensible but I don't know enough about what this code is supposed to do for the new architectures that it supports, e.g. ANDROID, ARM, APPLE. I'd really appreciate it if the devs who know more about those platforms could have a look.

The associated upstream cmyth diff to get XBMC and upstream to finally match can be found at dteirney/cmyth@5991469

@MartijnKaijser
Team Kodi member

ping anyone..

@Memphiz
Team Kodi member

I don't even know what libcmyth does in xbmc?

@fetzerch
Team Kodi member

Libcmyth is used to access a MythTV backend via the old myth:// protocol, that was used before PVR was implemented in XBMC: http://wiki.xbmc.org/?title=MythTV#Old-style_myth:.2F.2F_protocol_access
Starting with XBMC Frodo, the PVR addon for MythTV can be used for this.
The PVR addon supports everything that was possible with the myth:// protocol. (With EDL support being added to the Gotham PVR API)

I don't know what the team plans to do with such legacy sources, but I guess that it makes more sense to improve the PVR addons and to remove those legacy sources.

@elupus
Team Kodi member

I'm perfectly fine with this as long as it still seem to work. As long as it exists in our source, we should stay close to upstream.

jenkins test this please

@elupus
Team Kodi member

jenkins build this please

@Memphiz
Team Kodi member

Jenkins failed because this seems to be based on some Old master branch without jenkins Support - rebase please

@elupus
Team Kodi member

@dteirney think you could rebase it and build test it again?

@dteirney
Team Kodi member

Is any other part of XBMC using librefmem other than libcmyth? If not then we probably need to start considering how / when that functionality can be moved out to the PVR addon. The libcmyth library used by the PVR addon has also diverged further from upstream (and internal XBMC) and I've not had time to move that work upstream. There are still some gaps in PVR support compared to the existing myth:// protocol that would be good to close out somehow, e.g. Movies from the PVR recording list included in the XBMC Movie database. Would be great to get recorded TV Shows into the XBMC TV database as well.

@MartijnKaijser
Team Kodi member

jenkins build this please

@elupus elupus was assigned Oct 17, 2013
@MartijnKaijser
Team Kodi member

@dteirney care to update?

@dteirney
Team Kodi member

I've just updated to the MythTV PVR Addon for our use at home after upgrading to Myth 0.27, which the version of libcmyth in XBMC doesn't support.

There are a few things that the PVR Addon doesn't support that the standard File / Directory handling in XBMC does, which hasn't completely passed the WAF test, e.g. sorting by title does not appear to be possible in the PVR directories.

Anyway, overall I think we should look to deprecate and ultimately remove the current MythTV support within XBMC in favour of making the current PVR support better. What is the general protocol for removing parts of XBMC?

@jmarshallnz
Team Kodi member

Basically just throw up a PR to do the removal. I don't suspect there'll be much in the way of complaints if the PVR add-on is just about there anyway.

My understanding is that with the PVR window rewrite you'll get the sorting stuff (or at least it'll make it easier to do so).

@jmarshallnz
Team Kodi member

Oh, and if it's mostly the filesystem stuff that's being removed, then it may be that it can be moved to a binary add-on instead in the near future (i.e. next couple months).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment