Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JSON]Fix AudioLibrary.GetArtists with only "thumbnail" or "fanart" #14710

Merged
merged 1 commit into from Oct 25, 2018

Conversation

@DaveTBlake
Copy link
Member

commented Oct 25, 2018

Fix AudioLibrary.GetArtists when only one of "thumbnail" or "fanart" properties requested.

Reported https://forum.kodi.tv/showthread.php?tid=336804, when only one type of art property was requested (not both or "art") then only artists with that kind of art were returned, those with none were missing.

Tested on both SQLlite and MySQL (v5.7), with all combinations of "thumbnail", "fanart" and "art" properties, for example:

{"jsonrpc":"2.0", "id":1, "method":"AudioLibrary.GetArtists",
"params":{"properties":["thumbnail"]}}

Artists without art are correctly returned with empty values.

Patch bump to API version to indicate bug fixed by internal change

@DaveTBlake DaveTBlake force-pushed the DaveTBlake:JSONGetArtistsArtFix branch from 2c593a9 to 2a7601d Oct 25, 2018

@DaveTBlake DaveTBlake merged commit 33845e4 into xbmc:master Oct 25, 2018

1 check passed

default You're awesome. Have a cookie
Details

@DaveTBlake DaveTBlake deleted the DaveTBlake:JSONGetArtistsArtFix branch Oct 25, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.