Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JSON]Fix use of IsBroken method in addon serialization #14738

Merged
merged 1 commit into from Oct 30, 2018

Conversation

@DaveTBlake
Copy link
Member

commented Oct 29, 2018

Fix logic of addon is broken test after IsBroken method added by #14702 (Don't consider broken add-ons installable) that mistakenly replaced addon->Broken().empty() with the inverse addon->IsBroken()

Bump patch version to show that internal change has been made.

@garbear perhaps you can sanity check this is correct

@DaveTBlake

This comment has been minimized.

Copy link
Member Author

commented Oct 29, 2018

jenkins build this please

@DaveTBlake DaveTBlake merged commit 491eb05 into xbmc:master Oct 30, 2018

1 check passed

default You're awesome. Have a cookie
Details

@DaveTBlake DaveTBlake deleted the DaveTBlake:JSONAddonBrokenFix branch Oct 30, 2018

@garbear

This comment has been minimized.

Copy link
Member

commented Oct 30, 2018

thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.