Player capability flags #1474

Merged
merged 6 commits into from Oct 10, 2012

Conversation

Projects
None yet
3 participants
@theuni
Member

theuni commented Sep 24, 2012

As discussed at devcon.

This makes sure that we do not show settings that the player is not capable of handling.

For audio and subtitles, they're defined by the player.

For video (stretching, brightness, contrast, etc) they're handled by the renderer. The exception is bypass mode, where the player actually handles the display itself. If this is the case, the player is queried from the renderer.

ping @huceke you'll need to do this for omxplayer as well: b90a3e3a31526f56e3277bed088397ed1cd547fb

@elupus

This comment has been minimized.

Show comment
Hide comment
@elupus

elupus Sep 24, 2012

Member

References instead of pointers, otherwise looks fine.

Member

elupus commented Sep 24, 2012

References instead of pointers, otherwise looks fine.

@theuni

This comment has been minimized.

Show comment
Hide comment
@theuni

theuni Sep 24, 2012

Member

@elupus switched to references. went ahead and squashed it down since there was no other code discussion.

Member

theuni commented Sep 24, 2012

@elupus switched to references. went ahead and squashed it down since there was no other code discussion.

theuni added a commit that referenced this pull request Oct 10, 2012

@theuni theuni merged commit 056c785 into xbmc:master Oct 10, 2012

@theuni

This comment has been minimized.

Show comment
Hide comment
@theuni

theuni Oct 10, 2012

Member

ping @huceke . Reminder to fill these in for rpi :)

Member

theuni commented Oct 10, 2012

ping @huceke . Reminder to fill these in for rpi :)

@huceke

This comment has been minimized.

Show comment
Hide comment
@huceke

huceke Oct 10, 2012

Contributor

@theuni: quite late. not sure if i'll get it added in this merge window.

@cptspiff: is it ok when i add the caps to omxplayer till the weekend.

Contributor

huceke commented Oct 10, 2012

@theuni: quite late. not sure if i'll get it added in this merge window.

@cptspiff: is it ok when i add the caps to omxplayer till the weekend.

@ghost

This comment has been minimized.

Show comment
Hide comment
@ghost

ghost Oct 10, 2012

that would be acceptable.

ghost commented Oct 10, 2012

that would be acceptable.

LongChair added a commit to plexinc/plex-home-theater-public that referenced this pull request Feb 5, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment