Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP

Loading…

remove long deprecated HTTP-API #1475

Merged
merged 4 commits into from
@Montellese
Owner

With #1404 and #1465 taking care of the last bits for which the official iOS remote still uses the HTTP-API this commit gets rid of it completely by removing its code and usages.

I've tested this on win32 and linux and I also edited the xcode project files but not sure if just removing the entries is enough so I'll need some OSX dev to test that for me.

@garbear
Collaborator

but what about the ridiculously unsafe, non-sanitized direct database querying and arbitrary execution that xbmcQueryVideoDataBase() politely offered me???

@Montellese
Owner

You learn to live without it and use the filtering provided by JSON-RPC in methods like VideoLibrary.GetMovies et. al.

@koying
Collaborator

What about the official android remote?
The https://github.com/tombriden/android-xbmcremote/ fork does a great job in using JSON, but the official repo is still pure http-api...
And then, there is the thumbnail thingy ;)

@Montellese
Owner

We've discussed this internally. The official android remote is already partly broken because of database layout changes in xbmc itself e.g. tvshow section doesn't work anymore. freezy said he'll try to get it fully converted to JSON-RPC ASAP.

And the thumbnail thingy has nothing to do with the HTTP-API.

I've asked @cptspiff and he said to rip it out so I made this PR.

@koying
Collaborator
@mkortstiege
Collaborator

/me mumbles: die HTTP-API die.

@Tolriq

Any chance to have http://trac.xbmc.org/ticket/12678 investigate / corrected before Frodo ?
Since this is the last bit that make me use http api.

@jmarshallnz
Owner

You can send text directly via JSON-RPC to the keyboard dialog anyway (which will be utf8) - why do you need to send individual characters?

@Tolriq

Because in Yatse I use a full virtual keyboard that fill Xbmc dialogs as users write, and this was one of the most requested / welcomed function from users.

This is easier for them to write and correct with backspace than having an edit box that send full text and needs to do it again when mistakes and so on.

And also because I do direct physical keyboard to Xbmc.

I also have a direct to keymap mode but this one works ok.

@jmarshallnz
Owner

I don't understand why having an edit control on the TV is better than having an edit control on the remote control itself?

@Montellese
Owner

I agree with @jmarshallnz IMO it's easier to type on your phone and also look at your phone to see what you are typing than typing a character on the phone, then looking up at the tv screen to check if I made a typo and then look back down at the phone and type the next character. Just showing the typed character on the phone screen and being able to see and fix any typos there sounds a lot easier to me.

@koying
Collaborator
@Tolriq

There's always an edit that shows up in Xbmc interface for many case like filter or addons question, so no way to avoid this part :)

On remote side :

  • If the user have and physical keyboard he needs to open an editbox then fill then send, not natural. (And with same problems as non physical one)
  • if the user don't have one :
  • Current solution : a button shows a virtual keyboard like the one on screen and the box does fills has he type, the arrows / backspace and enter buttons have attended effects. With en edit box : The user write things then send and then auto commit on Xbmc. If mistakes lots of actions to start again. If don't auto commit then need 2 buttons a send and a commit less intuitive.

If send and no auto commit but dismiss on client side, on edit then the user needs to either rewrite the whole text he have written or if we always keep beetween session clear the text when a new dialog is shown.

To answer to Montellese : I can assure you now with SMS addicts & such this is really no more true users do look where the text should appears and absolutely not the keyboard. Do you still watch your keyboard when coding ? :)

And BTW since there's a eventserver command that does fill this needs and surely only needs a little fix/

To answer Koying : I don't say the new way is bad I just say the way I use eventserver is the way my users and I loves and prefer and would like to not loose :)

On a side note, removing http will also limits some remotes to get access to video actors, and removing vfs will kills constellation PVR functions :)

To finish on a good note Xbmc is really a cool app with lots of opening for remotes that contribute to it's success so would be cool to not kill some function assuming that best is better than good.

PS : My english is as usual far from good so no aggression or attacks in my text :)

@RobertMe

When the users opens the virtual keyboard you'll receive a notification (Input.OnKeyboardRequested if I remember correctly). One of the parameters the event has is the current value of the keyboard. So when the user has to correct a mistake you can still display the old value in the edit box. And besides that, nothing prevents you from sending the full text every time the value in the edit box changes. You'll just have to send the "done" parameter as false (otherwise it closes XBMCs virtual keyboard)

@koying
Collaborator
@koying
Collaborator
@Montellese
Owner

I think the way @RobertMe has pointed out should work for most of your use cases except for the ones where the user wants to move the cursor to fix something which will require a local edit box.

While you are right that I don't look at my keyboard while typing, this is a completely different use case. When using a computer, I watch at the screen because that's where all the information is. When using my phone I look at my phone's screen because that's where the information and input functionality is. So when I use my phone to type something I look at my phone and not at my telly.

@ghost

i dont understand why we are even discussing this. the removal of this was decided 2 years ago. it has had more than enough time in deprecated limbo.

@ghost ghost was assigned
@Tolriq

I'm not arguing about the removal, but just for a fix in EventServer that will allow some things to continue to work.
BTW EventServer is here to serve as an input service and should allow to input unicode chars.

But no problem I'll switch to what you all think is better for users and send them complaining here :)

And to finish with regarding the phone screen just try things like swipe keyboard and you'll understand how / why users don't look the phone.

All users wants gesture mode & such to have phone acting like a real remote, when I switch TV channel on my tv I don't have to watch where the numbers are because I know.

@jmarshallnz
Owner

Sure, so argue that in the trac ticket. Perhaps you'll garner enough interest for someone to look into it. Basically, if you can get someone to sort out sending an appropriate packet from the event server, and have that read in by the event client, I can probably take care of making sure it gets to the right spot inside XBMC (which I suspect is the problematic bit).

Now, let's stop spamming everyones mail boxes about this :)

@Tolriq

Ok so I'll make the PR for that :) Was already proposed a long time ago during discussions with Montellese :

http://forum.xbmc.org/showthread.php?tid=68263&pid=1012660#pid1012660

And the rest of the discussion :

#675

Sorry for the last mail here but don't want to work on PR that will be dropped since this is a longggggg and oldd discussion that have trends to get forgotten :)

@Montellese Montellese was assigned
@Montellese Montellese merged commit dbe719c into xbmc:master
@Albinoman887

so my script utilizing wget to update my video library will no longer fonction? So what is the alternative JSON?

@MartijnKaijser

JSON-RPC
see the wiki page for frodo

@Montellese
Owner

This is a discussion place for XBMC development, not for third party support. Ask your question in the forum or check the JSON-RPC v5 wiki page for a list of all the available methods.

@LongChair LongChair referenced this pull request from a commit in plexinc/plex-home-theater-public
@LongChair LongChair Dont use Paging for shortcuts, fixes #1475
We are setting all the shortcuts for teh section at once, so we dont't want to use paging on this request, otherwise, it only sets a few ones.
24d2482
@LongChair LongChair referenced this pull request from a commit in plexinc/plex-home-theater-public
@LongChair LongChair Insert Letters shortcut in the right order, and make dlanor happy, fi…
…xes #1475
597a349
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.