Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PVR][Estuary] Misc RDS changes #14784

Merged
merged 4 commits into from Nov 4, 2018

Conversation

@ksooo
Copy link
Member

commented Nov 3, 2018

Some RDS related changes:

  • Cleanup: Remove CPVRRadioRDSInfoTag member from CFileItem and make it a CPVRChannel property. No need and no functional gain to bloat CFileItem with this. Currently, an RDS tag is always tied to a CPVRChannel, so make it "part" of it. This change also fixes a bug with channel preview mode, where the rds tag got lost.

  • Refactor CPVRRadioRDSInfoTag and make it thread-safe. It is called from multiple threads. It worked only by luck so far.

  • Refactor CGUIDialogPVRRadioRDSInfo.

  • Estuary: Display RDS info line in PVR channel OSD.

screenshot001

@AlwinEsch good to go?
@ronie are the skin changes okay?

@ronie
ronie approved these changes Nov 3, 2018
@MartijnKaijser MartijnKaijser removed this from the Leia 18.0-beta5 milestone Nov 3, 2018
@ksooo ksooo force-pushed the ksooo:rds-misc branch from f664021 to 1ea0440 Nov 3, 2018
@ksooo ksooo force-pushed the ksooo:rds-misc branch 2 times, most recently from 4f6f910 to 7bc3f5b Nov 3, 2018
@AlwinEsch

This comment has been minimized.

Copy link
Member

commented Nov 4, 2018

The code looks good and much better, only looks it on skin a bit empty :-)

Something to keep the typical changing radio text, as we know it from radio devices?

@ksooo

This comment has been minimized.

Copy link
Member Author

commented Nov 4, 2018

... only looks it on skin a bit empty :-)

If you mean the text above the RDS line, this is the program plot from EPG. This can me a wall of text (then the info area is "full") or, like in my screen shot, just a few words.

Something to keep the typical changing radio text, as we know it from radio devices?

The RDS line changes dynamically, like it does on my car's radio screen.

@ksooo ksooo force-pushed the ksooo:rds-misc branch from 7bc3f5b to 4359f41 Nov 4, 2018
@ksooo ksooo force-pushed the ksooo:rds-misc branch from 4359f41 to f58aa19 Nov 4, 2018
@ksooo

This comment has been minimized.

Copy link
Member Author

commented Nov 4, 2018

jenkins build this please

@MartijnKaijser MartijnKaijser added this to the Leia 18.0-rc1 milestone Nov 4, 2018
@ksooo ksooo merged commit 734b375 into xbmc:master Nov 4, 2018
1 check passed
1 check passed
default You're awesome. Have a cookie
Details
@ksooo ksooo deleted the ksooo:rds-misc branch Nov 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.