clean up context menu entries #1488

Merged
merged 1 commit into from Oct 9, 2012

Projects

None yet

3 participants

@dersphere
Member

IMO the current mass of context menu entries is very confusing to new users so I created a list of entries which are (imo) contextual wrong and removed them. Most of them are add-on (both, script and plugin) related.

I committed very fine grained to have a detailed description on each remove. Of course I will squash all changes you want have applied into one commit later.

Please see details in each commit.

I know that my commits are even increasing the complexity of context menu entry creation but refactoring the hole context menu system exceeds my code knowledge.

@NedScott
Contributor
NedScott commented Oct 1, 2012

Stop scanning might be good to leave in regardless of where someone is. If you're on an ARM device, like an R-Pi or an ATV2, one might want to stop a library scan since these devices will really struggle to do anything while updating the library, including video add-ons.

@dersphere
Member

@NedScott: What about showing "stop scanning" if database is scanning but not showing "update library" when no scan is in progress?

@NedScott
Contributor
NedScott commented Oct 1, 2012

@dersphere Yeah, that would make sense.

@dersphere
Member

I squashed the changes into one commit with all requested changes.

Ready for next round :)

@MartijnKaijser
Member

@dersphere
Maybe also hide "scan for new content" (tvshows) while already scanning.

@dersphere
Member

@MartijnKaijser:
Button "Scan for new content" while on a source which contains TV-Shows was already correct. ("Scan for new Content" or "Stop Scanning" depending on IsVideoScanning)
Which button on which item do you exactly mean?

@dersphere
Member

@MartijnKaijser: Could you please recheck?

@MartijnKaijser
Member

So far works for me (of i have covered them all).

@dersphere
Member

@cptspiff: Is that something you consider merging in this (final) window?

@ghost
ghost commented Oct 7, 2012

yes.

@dersphere
Member

Just ping me if you want something to be changed.

@MartijnKaijser
Member

@dersphere
Could you rebase?

@dersphere
Member

@MartijnKaijser: Should be rebased now.

@dersphere dersphere context menu cleanup
changes:

video:
hide "update library" within or on video add-ons
hide "play from here" in context menu entries on scripts

music:
hide music related context menu entries on add-ons->"Get More..."
hide "update library" within or on video add-ons
hide "scan to library" in context menu entries on music->files->music add-ons
hide "switch media" in context menu entries within music plugin virtual folders

picture:
hide picture related context menu entries on add-ons->"Get More..."
hide "start slideshow( here)" in context menu entries on folders, zip, rar, cbz?, cbr?, scripts
hide "switch media" and "goto root" in context menu entries within or on picture plugins
63e9122
@MartijnKaijser MartijnKaijser merged commit 1ce0cf2 into xbmc:master Oct 9, 2012
@tru tru added a commit to plexinc/plex-home-theater-public that referenced this pull request Feb 5, 2015
@tru tru Avoid trying to load photo play queues since we don't support them.
Fixes #1488
3d9057f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment