Log database version to logfile #1492

Merged
merged 1 commit into from Oct 5, 2012

Conversation

Projects
None yet
4 participants
Contributor

vanosg commented Sep 28, 2012

As the database version is revamped, it can be tricky to keep different xbmc builds synchronized via a MySQL database since different versions of the xbmc database do not talk to each other. By logging this version number to the log file (it currently is not), it is easily accessible to the average user w/o needing to execute sql queries

Member

jmarshallnz commented Sep 28, 2012

You need to stick to XBMC coding style (braces on separate lines, no need
for braces on a one-line if).

Otherwise it looks OK (should only be called once per database).

On Fri, Sep 28, 2012 at 12:50 PM, vanosg notifications@github.com wrote:

As the database version is revamped, it can be tricky to keep different
xbmc builds synchronized via a MySQL database since different versions of
the xbmc database do not talk to each other. By logging this version number
to the log file (it currently is not), it is easily accessible to the

average user w/o needing to execute sql queries

You can merge this Pull Request by running:

git pull https://github.com/vanosg/xbmc master

Or view, comment on, or merge it at:

#1492
Commit Summary

  • Log database version to logfile

File Changes

  • M xbmc/dbwrappers/Database.cpp (3)

Patch Links

Contributor

vanosg commented Sep 28, 2012

New to the process - Should I make those changes and recomit/push? Or do you make those yourself when you merge? Thanks

Owner

Montellese commented Sep 28, 2012

Make the changes, commit them, rebase (git rebase -i) and squash the commits into one commit and then force push (git push -f) to your repository and the changed commit(s) will automatically be picked up by github and shown in this pull request.

Contributor

vanosg commented Sep 30, 2012

So, is this now ready for incorporation?

Owner

Montellese commented Oct 1, 2012

You first need to squash the two commits down into one (git rebase -i HEAD~2) and then force push the changes to your repo (git push -f origin master).

PS: Always create a new branch for every feature/change you make. That allows you to work on multiple features/changes simultaneously.

Contributor

vanosg commented Oct 5, 2012

I think this is ready to go

Memphiz merged commit 8de9ffd into xbmc:master Oct 5, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment