[pvr] Use CommonBackground in MyPVR.xml (confluence) #1494

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
3 participants
@fetzerch
Member

fetzerch commented Sep 28, 2012

Includes the "CommonBackground"s in MyPVR.
Together with #1455 this allows us to show fanarts for pvr recordings.

Cheers,
Christian

@JezzX

This comment has been minimized.

Show comment Hide comment
@JezzX

JezzX Sep 28, 2012

Member

Dont know if I like the idea of this if you actually look at the code the reason why it is separate is because I dont what 2 copies of the video visible when the use has the channels selected

Member

JezzX commented Sep 28, 2012

Dont know if I like the idea of this if you actually look at the code the reason why it is separate is because I dont what 2 copies of the video visible when the use has the channels selected

@fetzerch

This comment has been minimized.

Show comment Hide comment
@fetzerch

fetzerch Sep 28, 2012

Member

Sry, didn't look closely enough and thought it was forgotten after the big pvr merge.
Could you help me getting the fanarts shown for recordings? I think there are just a few lines missing in MyPVR.xml.

Member

fetzerch commented Sep 28, 2012

Sry, didn't look closely enough and thought it was forgotten after the big pvr merge.
Could you help me getting the fanarts shown for recordings? I think there are just a few lines missing in MyPVR.xml.

@JezzX

This comment has been minimized.

Show comment Hide comment
@JezzX

JezzX Sep 28, 2012

Member

Just adding an extra image control after the background ones and before the videos like this should do it (but not tested)

        <control type="image">
            <posx>0</posx>
            <posy>0</posy>
            <width>1280</width>
            <height>720</height>
            <aspectratio>scale</aspectratio>
            <texture background="true">$INFO[ListItem.Property(Fanart_Image)]</texture>
            <include>backgroundfade</include>
            <fadetime>FanartCrossfadeTime</fadetime>
            <visible>!Skin.HasSetting(HideBackGroundFanart) + !IsEmpty(ListItem.Property(Fanart_Image))</visible>
            <include>Window_OpenClose_Animation</include>
            <visible>![Player.HasVideo + !Skin.HasSetting(ShowBackgroundVideo)] + ![Player.HasAudio + !Skin.HasSetting(ShowBackgroundVis)]</visible>
        </control>
Member

JezzX commented Sep 28, 2012

Just adding an extra image control after the background ones and before the videos like this should do it (but not tested)

        <control type="image">
            <posx>0</posx>
            <posy>0</posy>
            <width>1280</width>
            <height>720</height>
            <aspectratio>scale</aspectratio>
            <texture background="true">$INFO[ListItem.Property(Fanart_Image)]</texture>
            <include>backgroundfade</include>
            <fadetime>FanartCrossfadeTime</fadetime>
            <visible>!Skin.HasSetting(HideBackGroundFanart) + !IsEmpty(ListItem.Property(Fanart_Image))</visible>
            <include>Window_OpenClose_Animation</include>
            <visible>![Player.HasVideo + !Skin.HasSetting(ShowBackgroundVideo)] + ![Player.HasAudio + !Skin.HasSetting(ShowBackgroundVis)]</visible>
        </control>
@fetzerch

This comment has been minimized.

Show comment Hide comment
@fetzerch

fetzerch Sep 28, 2012

Member

@JezzX Thanks, I've updated this PR after testing your propsal with #1455. Works fine!

Member

fetzerch commented Sep 28, 2012

@JezzX Thanks, I've updated this PR after testing your propsal with #1455. Works fine!

@fetzerch

This comment has been minimized.

Show comment Hide comment
@fetzerch

fetzerch Oct 4, 2012

Member

@opdenkamp since this is now closely related to the recording images support in #1455, any chance we get this in too for october? (its not assigned yet to the milestone)

Member

fetzerch commented Oct 4, 2012

@opdenkamp since this is now closely related to the recording images support in #1455, any chance we get this in too for october? (its not assigned yet to the milestone)

@ghost ghost assigned JezzX Oct 4, 2012

@opdenkamp

This comment has been minimized.

Show comment Hide comment
@opdenkamp

opdenkamp Oct 4, 2012

Member

looking fine to me. @JezzX ?

Member

opdenkamp commented Oct 4, 2012

looking fine to me. @JezzX ?

@JezzX

This comment has been minimized.

Show comment Hide comment
@JezzX

JezzX Oct 4, 2012

Member

The main reason I've not replied since is I think I might just bit the bullet and actually change the way the common one works so it can just use CommonBackground instead of adding in all this dupe code to the pvr window only as it harshes my karma

Member

JezzX commented Oct 4, 2012

The main reason I've not replied since is I think I might just bit the bullet and actually change the way the common one works so it can just use CommonBackground instead of adding in all this dupe code to the pvr window only as it harshes my karma

@JezzX

This comment has been minimized.

Show comment Hide comment
@JezzX

JezzX Oct 4, 2012

Member

CLosign this one because you can test this newer version instead #1533

Member

JezzX commented Oct 4, 2012

CLosign this one because you can test this newer version instead #1533

@JezzX JezzX closed this Oct 4, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment