Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[json-rpc][pvr] Fix 'PVR.Record'. #15093

Merged
merged 1 commit into from Dec 20, 2018

Conversation

@ksooo
Copy link
Member

commented Dec 19, 2018

Bug reported in the forum: https://forum.kodi.tv/showthread.php?tid=337964

I bumped the json-rpc micro version to make it possible to determine whether the bug fix is in place - the change is fully API compatible as the API itself is not affected.

Cause of the bug was a stupid and simple logical error.

@ksooo ksooo added this to the Leia 18.0-rc4 milestone Dec 19, 2018

@ksooo ksooo requested a review from DaveTBlake Dec 19, 2018

@ksooo

This comment has been minimized.

Copy link
Member Author

commented Dec 20, 2018

@ksooo

This comment has been minimized.

Copy link
Member Author

commented Dec 20, 2018

I will merge this tomorrow if nobody objects. As you can see the fix is trivial.

@MartijnKaijser

This comment has been minimized.

Copy link
Member

commented Dec 20, 2018

Go ahead

@ksooo ksooo merged commit 738f4f8 into xbmc:master Dec 20, 2018

1 check passed

default You're awesome. Have a cookie
Details

@ksooo ksooo deleted the ksooo:jsonrpc-pvr-record branch Dec 20, 2018

@DaveTBlake
Copy link
Member

left a comment

Thanks for this @ksooo (sorry for delay but have been off line a few days)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.