Join GitHub today
PVRClient: Do not overwrite arbitrary memory fixes #15157 #15168
Although the fix is okay - have you guys tested with pvr.hts or did you use another addon?
As far as I can see, pvr.hts cuts the description string and thus no buffer overflow should be possible: https://github.com/kodi-pvr/pvr.hts/blob/master/src/Tvheadend.cpp#L741
@fritsch Ah, now I see the problem. I would fix it like this (shorter than your solution):
strncpy(types_array[i].strDescription, descr.c_str(), sizeof(types_array[i].strDescription) - 1);
PS: I thought it would be a problem with an addon-supplied string which is actually not the case. ;-)