FIX: UPnP: Checking music for "Loaded()" is never true for artists => ba... #1517

Merged
1 commit merged into from Oct 1, 2012

Conversation

Projects
None yet
1 participant
@koying
Contributor

koying commented Oct 1, 2012

...d performances.

As we are coming from the music db, I think we are pretty sure it is TRUE for songs and albums, anyway.

@ghost

This comment has been minimized.

Show comment Hide comment
@ghost

ghost Oct 1, 2012

hmm, i ponder if not setting Loaded in the first place is sane or not..

ghost commented Oct 1, 2012

hmm, i ponder if not setting Loaded in the first place is sane or not..

@koying

This comment has been minimized.

Show comment Hide comment
@koying

koying Oct 1, 2012

Contributor

For artists, you mean? Well, Loaded (I think) is supposed to mean that info
has been extracted from the files.

This doesn't make sense sense for artists.
Le 1 oct. 2012 19:09, "Arne Morten Kvarving" notifications@github.com a
écrit :

hmm, i ponder if not setting Loaded in the first place is sane or not..


Reply to this email directly or view it on GitHubhttps://github.com/xbmc/xbmc/pull/1517#issuecomment-9041337.

Contributor

koying commented Oct 1, 2012

For artists, you mean? Well, Loaded (I think) is supposed to mean that info
has been extracted from the files.

This doesn't make sense sense for artists.
Le 1 oct. 2012 19:09, "Arne Morten Kvarving" notifications@github.com a
écrit :

hmm, i ponder if not setting Loaded in the first place is sane or not..


Reply to this email directly or view it on GitHubhttps://github.com/xbmc/xbmc/pull/1517#issuecomment-9041337.

@ghost

This comment has been minimized.

Show comment Hide comment
@ghost

ghost Oct 1, 2012

right.

ghost commented Oct 1, 2012

right.

ghost pushed a commit that referenced this pull request Oct 1, 2012

Arne Morten Kvarving
Merge pull request #1517 from koying/upnploaded
FIX: UPnP: Checking music for "Loaded()" is never true for artists => ba...

@ghost ghost merged commit 0cebf98 into xbmc:master Oct 1, 2012

tru added a commit to plexinc/plex-home-theater-public that referenced this pull request Apr 30, 2015

This issue was closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment