Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[wayland] Request new frame cb only when previous one was signaled #15193

Merged
merged 1 commit into from Jan 3, 2019

Conversation

@pkerling
Copy link
Member

commented Jan 3, 2019

Continuously requesting new frame callbacks even when the last one has
not been signaled generates a lot of unnecessary traffic on the Wayland
connection and has the potential to exhaust the object ID space (since
every callback is a separate object) when the surface is not visible for
a very long time. Also, already for short time spans the compositor
might have problems buffering all delete_id() messages being sent at
once at the moment the surface becomes visible again.

Continuously requesting new frame callbacks even when the last one has
not been signaled generates a lot of unnecessary traffic on the Wayland
connection and has the potential to exhaust the object ID space (since
every callback is a separate object) when the surface is not visible for
a very long time. Also, already for short time spans the compositor
might have problems buffering all delete_id() messages being sent at
once at the moment the surface becomes visible again.
@pkerling pkerling self-assigned this Jan 3, 2019
@pkerling pkerling added this to the Leia 18.0-rc5 milestone Jan 3, 2019
@pkerling pkerling merged commit 79873d8 into xbmc:master Jan 3, 2019
1 check passed
1 check passed
default You're awesome. Have a cookie
Details
@pkerling pkerling deleted the pkerling:wayland-frame-cb branch Jan 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.