Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HTTP2 client support #15195

Merged
merged 2 commits into from Feb 21, 2019

Conversation

Projects
None yet
6 participants
@wsnipex
Copy link
Member

commented Jan 4, 2019

Description

This adds HTTP2 support in curl for depends platforms.
Windows would need some love, but libnghttp2 doesn't need any dependencies we don't already have

Motivation and Context

How Has This Been Tested?

only on linux, via youtube plugin

Types of change

  • Bug fix (non-breaking change which fixes an issue)
  • Clean up (non-breaking change which removes non-working, unmaintained functionality)
  • Improvement (non-breaking change which improves existing functionality)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that will cause existing functionality to change)
  • Cosmetic change (non-breaking change that doesn't touch code)
  • None of the above (please explain below)

Checklist:

  • My code follows the Code Guidelines of this project
  • My change requires a change to the documentation, either Doxygen or wiki
  • I have updated the documentation accordingly
  • I have read the Contributing document
  • I have added tests to cover my change
  • All new and existing tests passed
@wsnipex

This comment has been minimized.

Copy link
Member Author

commented Jan 4, 2019

I'm unsure if we should consider this for v18. It's very late in the cycle, but otoh rather low impact.

@MartijnKaijser

This comment has been minimized.

Copy link
Member

commented Jan 4, 2019

Maybe for point release?

@wsnipex

This comment has been minimized.

Copy link
Member Author

commented Jan 4, 2019

I thought about that as well, so fine for me

@MartijnKaijser MartijnKaijser added this to the Leia 18.1-rc1 milestone Jan 4, 2019

@afedchin

This comment has been minimized.

Copy link
Member

commented Jan 4, 2019

Windows would need some love, but libnghttp2 doesn't need any dependencies we don't already have

vcpkg proj has nhttp2 port, so windows isn't an issue but need some time to compile

@wsnipex

This comment has been minimized.

Copy link
Member Author

commented Jan 31, 2019

@afedchin any news?

@afedchin

This comment has been minimized.

Copy link
Member

commented Jan 31, 2019

@wsnipex about what? do you need compiled libs? @Rechi can help you, he re-compiled curl recently iirc.

@wsnipex

This comment has been minimized.

Copy link
Member Author

commented Feb 1, 2019

hm ok, I interpreted your last comment as if you would compile it.
just for completeness: I don't need the windows port, I can merge this as is(without windows support)

@MartijnKaijser

This comment has been minimized.

Copy link
Member

commented Feb 10, 2019

@Rechi can you compile new libs or do we merge it without windows updated?

@Rechi

This comment has been minimized.

Copy link
Member

commented Feb 10, 2019

Not going to touch windows depends for this feature in a point release.

@wsnipex

This comment has been minimized.

Copy link
Member Author

commented Feb 17, 2019

Jenkins build this please

@wsnipex

This comment has been minimized.

Copy link
Member Author

commented Feb 21, 2019

jenkins build and merge

@jenkins4kodi jenkins4kodi merged commit e517ffc into xbmc:master Feb 21, 2019

1 check was pending

default Found some time, building it now.
Details

@Rechi Rechi added the v18 Leia label Feb 21, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.