Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Teletext] Correct order of colors in the bottom line #15207

Merged
merged 1 commit into from Jan 6, 2019

Conversation

@engelmarkus
Copy link
Contributor

commented Jan 6, 2019

Description

I've noticed that in the teletext window the order of the colors in the bottom seems to be wrong:
colors_wrong

On remote controls, the order is usually "red green yellow blue". Note that the buttons work correctly, e. g. the second button opens the page shown in the second field, only the colors of the second and third field are exchanged.
This little patch fixes the problem.
colors_right

Types of change

  • Bug fix (non-breaking change which fixes an issue)
  • Clean up (non-breaking change which removes non-working, unmaintained functionality)
  • Improvement (non-breaking change which improves existing functionality)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that will cause existing functionality to change)
  • Cosmetic change (non-breaking change that doesn't touch code)
  • None of the above (please explain below)

Checklist:

  • My code follows the Code Guidelines of this project
  • My change requires a change to the documentation, either Doxygen or wiki
  • I have updated the documentation accordingly
  • I have read the Contributing document
  • I have added tests to cover my change
  • All new and existing tests passed
@ksooo
ksooo approved these changes Jan 6, 2019
Copy link
Member

left a comment

Makes sense. Thanks for your contribution.

@ksooo ksooo merged commit c81be5b into xbmc:master Jan 6, 2019
1 check passed
1 check passed
default You're awesome. Have a cookie
Details
@ksooo ksooo added this to the Leia 18.0-rc5 milestone Jan 6, 2019
@ksooo ksooo changed the title Correct order of colors in the bottom line [Teletext] Correct order of colors in the bottom line Jan 6, 2019
MartijnKaijser added a commit to MartijnKaijser/xbmc that referenced this pull request Jan 22, 2019
Correct order of colors in the bottom line
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.