Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DisplaySettings: Change %.02f to %.2f to workaround a crash in libfmt53 #15224

Merged
merged 3 commits into from Jan 12, 2019

Conversation

fritsch
Copy link
Member

@fritsch fritsch commented Jan 9, 2019

This workarounds: http://ix.io/1xOT which worked perfectly fine in older libfmt versions

@fritsch
Copy link
Member Author

fritsch commented Jan 9, 2019

@DanielaE could you take a look?

@DanielaE
Copy link

DanielaE commented Jan 10, 2019

Hallo Peter!

With commit e015792, {fmt} tightened the parsing of literal integral fields in the formatting specification such that they no longer are allowed to start with zeros. This aligns the parsing within the formatting specification string to the same parsing rules of decimal integer literals outside of strings as defined in C or C++. In fact, after some roaming the internet for printf formatting specifications I've never encountered any example which would show an integer literal with leading zeros. Seemingly leading zeros are not part of integral literals but a formatting specifier on their own which cannot happen in the precision field.

The crash that you are experiencing is probably due to the exception thrown in the parser of the printf-type syntax.

@fritsch
Copy link
Member Author

fritsch commented Jan 10, 2019

@DanielaE Thank you very much for detailled answer.

@Rechi @pkerling let's fix all our identifiers, for final?

@MartijnKaijser
Copy link
Member

Jenkins build this please

@MartijnKaijser MartijnKaijser added Type: Fix non-breaking change which fixes an issue v18 Leia labels Jan 11, 2019
@MartijnKaijser
Copy link
Member

Jenkins build this please
Must do or good for point release?

@yol
Copy link
Member

yol commented Jan 11, 2019 via email

@fritsch
Copy link
Member Author

fritsch commented Jan 12, 2019

Rebuilding: https://jenkins.kodi.tv/job/LINUX-64/12153/ Linux64 only

@MartijnKaijser MartijnKaijser added this to the Leia 18.0-rc5 milestone Jan 12, 2019
@MartijnKaijser MartijnKaijser merged commit 2e77047 into xbmc:master Jan 12, 2019
@MartijnKaijser
Copy link
Member

Retriggered the build manually

MartijnKaijser added a commit to MartijnKaijser/xbmc that referenced this pull request Jan 22, 2019
DisplaySettings: Change %.02f to %.2f to workaround a crash in libfmt53
@fritsch fritsch mentioned this pull request Feb 26, 2019
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Fix non-breaking change which fixes an issue v18 Leia
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants