Clang fix #1535

Merged
merged 2 commits into from Sep 5, 2013

4 participants

@Fneufneu
Team Kodi member

On FreeBSD, i need 2 fix to be able to build XBMC with clang.

tested with clang 3.1 and 3.2 (trunk)

@theuni
Team Kodi member

That's all it took? nice :)

@ghost

well the disabling of logging is hardly a fix ;)

@Memphiz
Team Kodi member

Its an anti-feature. Based on merge windows this has to be merged outside of a merge window or hell on earth or so :p

@Memphiz
Team Kodi member

Strange we use clang 3.1 on osx since "ages" without problems...

@MartijnKaijser
Team Kodi member

@Fneufneu ping (there's also a merge master commit in here)

@theuni
Team Kodi member

@Fneufneu ping. Out of curiosity I tested with linux/android, and had similar results there. So this is valuable all around. Please see the top 3 commits at: https://github.com/theuni/xbmc/commits/clang

I believe that the 2nd one (theuni@7f60b54) is the real fix for cpluff. Mind having a look?

@Fneufneu
Team Kodi member

@theuni good catch ! your cpluff fix works here.
i added a new needed fix 8ef2bf109f7136788aa3ec86717b2fbb98ae31bf
can you take a look ?

@theuni
Team Kodi member

@Fneufneu If I understand correctly, it seems you've pushed the (seemingly correct) fix into mainline, so 7705bae isn't needed anymore? If that's what you meant, then sure, I agree.

@theuni
Team Kodi member

Mm.. ignore that. Github is doing really strange things with links. 8ef2bf1 points to the XBMC repo for some reason...

Anyway, fix looks fine.

@Fneufneu
Team Kodi member

you scared me for a minute ! :)

anyway, how you want to proceed, you make a new clean PR and we close this one ?

Fneufneu added some commits Oct 4, 2012
Fneufneu [clang] fix rsxs screensaver build
clang need to known that we use some gnu inline semantics
a875bcf
Fneufneu clang: fix declaration of default arg
depend on os/clang version it's a warning or an error:
error: addition of default argument on redeclaration makes
    this constructor a default constructor
warning: addition of default argument on redeclaration makes
    this constructor a default constructor

full errors: http://pastebin.com/tnJXZV8L
700a245
@Fneufneu Fneufneu merged commit 9a505c6 into xbmc:master Sep 5, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment